New patch submitted by Eduardo Warszawski (ewarszaw(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/930
commit e945109a87795cef5c32150b574228c31fc6aea7
Author: Eduardo Warszawski <ewarszaw(a)redhat.com>
Date: Tue Sep 13 10:39:31 2011 +0300
BZ#736301 - Don't fail lvm.getVGbyUUID() if unredable VGs found.
Change-Id: Ief82082ebb3cfb6731dc9c7905f2844c60a7f425
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 9bf8533..257616d 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -820,12 +820,18 @@ def getVG(vgName):
def getAllVGs():
return _lvminfo.getAllVgs() #returns list
-
+# TODO: lvm VG UUID should not be exposed.
+# Remove this function when hsm.public_createVG is removed.
def getVGbyUUID(vgUUID):
# cycle through all the VGs until the one with the given UUID found
for vg in getAllVGs():
- if vg.uuid == vgUUID:
- return vg
+ try:
+ if vg.uuid == vgUUID:
+ return vg
+ except AttributeError, e:
+ # An unreloadable VG found but may be we are not looking for it.
+ log.debug("%s" % e.message, exc_info=True)
+ continue
# If not cry loudly
raise se.VolumeGroupDoesNotExist("vg_uuid: %s" % vgUUID)
Igor Lvovsky has posted comments on this change.
Change subject: Add partial vms list support to the regular 'list' query.
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File vdsm/clientIF.py
Line 692: d = vm.status()
Line 693: if full:
Line 694: return d
Line 695: else:
Line 696: return {'vmId': d['vmId'], 'status': d['status']}
I can't understand what are you want here
Line 697: return {'status': doneCode,
Line 698: 'vmList': [reportedStatus(vm, full) for vm in self.vmContainer.values()
Line 699: if not vms or vm.id in vms]}
Line 700:
....................................................
File vdsm_cli/vdsClient.py
Line 207: view = 'long' #Default view
Line 208: vms = []
Line 209:
Line 210: if args:
Line 211: if args[0].startswith('vms:'):
No, you still can use 'vms:' without 'table/long/ids' parameter
Line 212: vms = _vmsParser(args[0])
Line 213: else:
Line 214: view = args[0]
Line 215: if len(args) > 1 and args[1].startswith('vms:'):
Line 222: #if not vms:
Line 223: for res in self.s.getAllVmStats()['statsList']:
Line 224: if not vms or res['vmId'] in vms:
Line 225: allStats[ res['vmId'] ] = res
Line 226: #else:
Done
Line 227: # for vm in vms:
Line 228: # res = self.s.getVmStats(vm)['statsList']
Line 229: # allStats[vm] = res[0]
Line 230:
--
To view, visit http://gerrit.usersys.redhat.com/956
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5051c42ca9e4ce706eff3cfec0de04cd76b2b95f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Federico Simoncelli has posted comments on this change.
Change subject: BZ#740887 Tune cache dirty ratio
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/vdsmd.in
Line 366: if [ $? -ne 0 ]; then
Line 367: echo $"Configuring sysctl for vdsm..."
Line 368: sed -e '/vm.dirty_ratio/d' \
Line 369: -e '/vm.dirty_background_ratio/d' \
Line 370: -e '/# VDSM section begin/,/# VDSM section end/d' \
I moved the parameters to sysctl.conf so the sysadmin will know right away where the changes are coming from. It also supports versioning (if we decide to change the parameters in the future we can).
Line 371: /etc/sysctl.conf > /etc/sysctl.conf.vdsm
Line 372: cat >> /etc/sysctl.conf.vdsm <<EOF
Line 373: $VDSM_SYSCTL_HEAD
Line 374: vm.dirty_ratio = 5
--
To view, visit http://gerrit.usersys.redhat.com/970
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5c8e4c0637c60092b89fba103b96b37bdafaa0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Federico Simoncelli has posted comments on this change.
Change subject: BZ#732980 Initialize the block sizes metadata
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 242: self.metavol = lvm.lvPath(self.sdUUID, sd.METADATA)
Line 243:
Line 244: try:
Line 245: self.logBlkSize = self.getMetaParam(DMDK_LOGBLKSIZE)
Line 246: self.phyBlkSize = self.getMetaParam(DMDK_PHYBLKSIZE)
Both values must be set in the metadata asap since we need them to understand if in the future they have changed (eg: a cloned lun but somehow exposing a different block size).
Line 247: except KeyError:
Line 248: # Initialize the block sizes metadata if not defined
Line 249: self.logBlkSize, self.phyBlkSize = lvm.getVGBlockSizes(sdUUID)
Line 250: self.setMetaParam(DMDK_LOGBLKSIZE, self.logBlkSize)
--
To view, visit http://gerrit.usersys.redhat.com/992
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0baa4addabc31389ea1656099f7c9d2d70cd85a0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Federico Simoncelli has posted comments on this change.
Change subject: Don't pollute the root directory during installation
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm.spec.in
Line 100: echo -n shibboleth > "$pfile"
Line 101: /bin/chown vdsm:kvm "$pfile"
Line 102: new_pwd=1
Line 103: fi
Line 104: if ! /usr/sbin/sasldblistusers2 -f /etc/libvirt/passwd.db 2> /dev/null | \
Have you ever wondered where the "/-" file was coming from? :-)
Line 105: /bin/grep -q '^vdsm@rhevh\b' || [[ -n "$new_pwd" ]] ;
Line 106: then
Line 107: /usr/sbin/saslpasswd2 -p -a libvirt vdsm@rhevh < "$pfile"
Line 108: fi
--
To view, visit http://gerrit.usersys.redhat.com/996
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c8e4f4253e03f6fa6fe249f29eeac1ea4619817
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: Related to BZ#743272 - dirList IS and WAS dirList.
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
Putting the task id in set() is not really required... I don't expect any duplicates there. But it is what the former code did, so ok.
--
To view, visit http://gerrit.usersys.redhat.com/993
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fbcdb4076a5c16fd74754350464f382636ff419
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
Patch was abandoned by Igor Lvovsky (ilvovsky(a)redhat.com) because: We have real logger now
You can review this change at: http://gerrit.usersys.redhat.com/986
Igor Lvovsky has abandoned this change.
Change subject: Stupid logger to get mount errors
......................................................................
Patch Set 1: Abandoned
We have real logger now
--
To view, visit http://gerrit.usersys.redhat.com/986
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I7530424ead0588e0843cece29c5c78216b505d0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#741856 delete rhevm cert before conf_update
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/987
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bc1dc1fb7fa2ffc0bcb1f6389b34a9ee82b4197
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove unused TaskResource class
......................................................................
Remove unused TaskResource class
Change-Id: Ib487ff8661c771b765afed1f97327ef88c798745
---
M vdsm/storage/task.py
1 file changed, 0 insertions(+), 27 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/980
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib487ff8661c771b765afed1f97327ef88c798745
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>