Change in vdsm[master]: BZ#741856 delete rhevm cert before conf_update
by Yotam Oron
Yotam Oron has posted comments on this change.
Change subject: BZ#741856 delete rhevm cert before conf_update
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File vdsm_reg/deployUtil.py.in
Line 1327: return data
Line 1328:
Line 1329: def nodeCleanup():
Line 1330: if isOvirt():
Line 1331: CACERT, dontcare = certPaths('')
Done
Line 1332: if os.path.exists(CACERT):
Line 1333: ovirtfunctions.ovirt_safe_delete_config(CACERT)
Line 1334:
Line 1335: def getRhevmCert(IP, port):
....................................................
File vdsm_reg/vdsm-config
Line 82: sed --copy -i "s/\(^vdc_host_name=\)\(..*$\)/\1${vdc_managment_server}/" \
Line 83: /etc/vdsm-reg/vdsm-reg.conf
Line 84:
Line 85: res=`python "$DEPLOY_UTIL" --node-cleanup`
Line 86: ret_val=$?
ERRRRR !!! I HATE THOSE FREAKIN' TABS !! :-)
Done.
Line 87: echo "$res" >> $LOG 2>&1
Line 88: if [ ! $ret_val -eq 0 ];then
Line 89: echo "Node cleanup failed" >> $LOG 2>&1
Line 90: fi
--
To view, visit http://gerrit.usersys.redhat.com/987
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bc1dc1fb7fa2ffc0bcb1f6389b34a9ee82b4197
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
12 years, 8 months
Change in vdsm[master]: BZ#737722 Do not pass cmdline args to grub in RHEV-H
by Yotam Oron
Yotam Oron has posted comments on this change.
Change subject: BZ#737722 Do not pass cmdline args to grub in RHEV-H
......................................................................
Patch Set 2: Verified
--
To view, visit http://gerrit.usersys.redhat.com/988
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3347e60ecbf88f3c8e198d36104dfc55ebdee288
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
12 years, 8 months
Change in vdsm[master]: BZ#737722 Do not pass cmdline args to grub in RHEV-H
by Yotam Oron
Yotam Oron has posted comments on this change.
Change subject: BZ#737722 Do not pass cmdline args to grub in RHEV-H
......................................................................
Patch Set 1: (2 inline comments)
....................................................
Commit Message
Line -2
Line -1
Line 0
Line 1: Parent: 6a469b6d (BZ#716573 make vdsm's `ulimit -n` configurable)
Line 2: Author: Yotam Oron <yoron(a)redhat.com>
Not that different, only the keywords have changed
Line 3: AuthorDate: 2011-10-03 18:03:13 +0200
Line 4: Commit: Yotam Oron <yoron(a)redhat.com>
Line 5: CommitDate: 2011-10-03 18:03:13 +0200
Line 6:
Line 3: AuthorDate: 2011-10-03 18:03:13 +0200
Line 4: Commit: Yotam Oron <yoron(a)redhat.com>
Line 5: CommitDate: 2011-10-03 18:03:13 +0200
Line 6:
Line 7: BZ#737722 Do not pass cmdline args to grub
Done
Line 8:
Line 9: cmdline args are only needed in installation time,
Line 10: oVirt has a builtin functionallity to not pass the args
Line 11: to grub
--
To view, visit http://gerrit.usersys.redhat.com/988
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3347e60ecbf88f3c8e198d36104dfc55ebdee288
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
12 years, 8 months
Change in vdsm[master]: BZ#741856 delete rhevm cert before conf_update
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#741856 delete rhevm cert before conf_update
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm_reg/deployUtil.py.in
Line 1327: return data
Line 1328:
Line 1329: def nodeCleanup():
Line 1330: if isOvirt():
Line 1331: CACERT, dontcare = certPaths('')
having _ instead of "dontcare" is cooler ;-)
Line 1332: if os.path.exists(CACERT):
Line 1333: ovirtfunctions.ovirt_safe_delete_config(CACERT)
Line 1334:
Line 1335: def getRhevmCert(IP, port):
....................................................
File vdsm_reg/vdsm-config
Line 82: sed --copy -i "s/\(^vdc_host_name=\)\(..*$\)/\1${vdc_managment_server}/" \
Line 83: /etc/vdsm-reg/vdsm-reg.conf
Line 84:
Line 85: res=`python "$DEPLOY_UTIL" --node-cleanup`
Line 86: ret_val=$?
sorry, tab alert
Line 87: echo "$res" >> $LOG 2>&1
Line 88: if [ ! $ret_val -eq 0 ];then
Line 89: echo "Node cleanup failed" >> $LOG 2>&1
Line 90: fi
--
To view, visit http://gerrit.usersys.redhat.com/987
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bc1dc1fb7fa2ffc0bcb1f6389b34a9ee82b4197
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
12 years, 8 months
Change in vdsm[master]: Stupid logger to get mount errors
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Stupid logger to get mount errors
......................................................................
Patch Set 1: I would prefer that you didn't submit this
--
To view, visit http://gerrit.usersys.redhat.com/986
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7530424ead0588e0843cece29c5c78216b505d0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
12 years, 9 months
Change in vdsm[master]: BZ#737722 Do not pass cmdline args to grub
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#737722 Do not pass cmdline args to grub
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
Commit Message
Line -2
Line -1
Line 0
Line 1: Parent: 6a469b6d (BZ#716573 make vdsm's `ulimit -n` configurable)
Line 2: Author: Yotam Oron <yoron(a)redhat.com>
is it much different than Alan's patch?
Line 3: AuthorDate: 2011-10-03 18:03:13 +0200
Line 4: Commit: Yotam Oron <yoron(a)redhat.com>
Line 5: CommitDate: 2011-10-03 18:03:13 +0200
Line 6:
Line 3: AuthorDate: 2011-10-03 18:03:13 +0200
Line 4: Commit: Yotam Oron <yoron(a)redhat.com>
Line 5: CommitDate: 2011-10-03 18:03:13 +0200
Line 6:
Line 7: BZ#737722 Do not pass cmdline args to grub
Please mention this is RHEV-H cmdline
Line 8:
Line 9: cmdline args are only needed in installation time,
Line 10: oVirt has a builtin functionallity to not pass the args
Line 11: to grub
--
To view, visit http://gerrit.usersys.redhat.com/988
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3347e60ecbf88f3c8e198d36104dfc55ebdee288
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 9 months
Change in vdsm[master]: Stupid logger to get mount errors
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: Stupid logger to get mount errors
......................................................................
Patch Set 1: (1 inline comment)
unless we get http://gerrit.usersys.redhat.com/985 to quickly work, we should at least have this one ready to post for reproducers.
....................................................
File vdsm/storage/fileUtils.py
Line 71: logDir = "/var/log/vdsm/mount/"
Line 72: def _stupidLogger(out):
Line 73: if not os.path.exists(logDir):
Line 74: os.makedirs(logDir)
Line 75: logFile = logDir + str(os.getpid())
It would be better to call logging.basicConfig with the filename. this way we'd get all logging.bla for free.
Line 76: with open(logFile, 'a') as f:
Line 77: f.write(out + "\n")
Line 78:
Line 79: def mount(resource, mountPoint, mountType):
--
To view, visit http://gerrit.usersys.redhat.com/986
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7530424ead0588e0843cece29c5c78216b505d0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
12 years, 9 months
Change in vdsm[master]: BZ#742267 server_connection: checking access is enough
by Igor Lvovsky
Igor Lvovsky has posted comments on this change.
Change subject: BZ#742267 server_connection: checking access is enough
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
just to be sure. did you run some simple testing (vmTests) for all storage types?
--
To view, visit http://gerrit.usersys.redhat.com/983
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I799374f13cc9d5fe193d76479f738e0a5fa02836
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
12 years, 9 months