Igor Lvovsky has posted comments on this change.
Change subject: BZ#732765 - Drop disktotal/diskfree parameters for unreachable domains
......................................................................
Patch Set 1: Verified
Verified with Mike on his setup
--
To view, visit http://gerrit.usersys.redhat.com/1003
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie359e5fb70cd5dc2e59f8d9e166fb02ba3307273
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Yotam Oron has posted comments on this change.
Change subject: BZ#740158 netinfo.speed(): never report -1 speed
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/1001
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I309bc4940405ebfe73fdcbe36f83db33a426fee5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#737722 Do not pass cmdline args to grub in RHEV-H
......................................................................
BZ#737722 Do not pass cmdline args to grub in RHEV-H
cmdline args are only needed in installation time,
oVirt has a builtin functionallity to not pass the args
to grub
Change-Id: I3347e60ecbf88f3c8e198d36104dfc55ebdee288
---
M vdsm.spec.in
M vdsm_reg/Makefile.am
A vdsm_reg/vdsm-reg-cmdline
3 files changed, 11 insertions(+), 0 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/988
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3347e60ecbf88f3c8e198d36104dfc55ebdee288
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#737722 Do not pass cmdline args to grub in RHEV-H
......................................................................
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.usersys.redhat.com/988
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3347e60ecbf88f3c8e198d36104dfc55ebdee288
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#737722 Do not pass cmdline args to grub in RHEV-H
......................................................................
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.usersys.redhat.com/988
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3347e60ecbf88f3c8e198d36104dfc55ebdee288
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
David Naori has posted comments on this change.
Change subject: Related to BZ#738120 - Logging in OOP.
......................................................................
Patch Set 4: Fails
it logs every execCmd (mount, umount) 3 times...
--
To view, visit http://gerrit.usersys.redhat.com/985
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabe8abf31f46469e3c6fdac670f0ff03fe9cefe8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#740887 Tune cache dirty ratio
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/vdsmd.in
Line 360:
Line 361: configure_sysctl()
Line 362: {
Line 363: local VDSM_SYSCTL_HEAD
Line 364: VDSM_SYSCTL_HEAD="# VDSM section begin (v.1)"
it would have been more robust to set this to "# VDSM section begin ", and append it with the version. then the same var could be used by sed.
Line 365: grep -q "$VDSM_SYSCTL_HEAD" /etc/sysctl.conf
Line 366: if [ $? -ne 0 ]; then
Line 367: echo $"Configuring sysctl for vdsm..."
Line 368: sed -e '/vm.dirty_ratio/d' \
Line 393: args="$args $LCONF $QCONF $LDCONF"
Line 394: ;;
Line 395: esac
Line 396: configure_libvirt $args
Line 397: configure_sysctl $args
no use for "$args" here.
Line 398: }
Line 399:
Line 400: stop_libvirtd_sysv() {
Line 401: # stop libvirt SysV service if we intend to configure upstart
--
To view, visit http://gerrit.usersys.redhat.com/970
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5c8e4c0637c60092b89fba103b96b37bdafaa0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>