hi james,
message accepted to tuna-devel
keep in mind:
- it is dependency of tuna and with that in mind was brought back to
kernel.org
- it contains pss and psk utilities, usefull at least for testing
first glance (well first test):
before:
- on arm it just didn't worked, resulting in python error traceback
- on x86 worked (tuna -nCP, pss, psk)
after:
- on arm coredumping python tuna and psk, pss doens't show anything
- on x86 pss doesn't show anything, psk coredumping python and tuna -nCP
doesn't show sockets
so without rework, it can't be accepted.
best regards
jiri kastner
On Tue, Oct 14, 2014 at 12:51:37PM +0200, James wrote:
Hello Jiri,
I have created a public repository with my github account so you can access my
patches more easily:
https://github.com/hulkamania/python-inet_diag
Upon preparing everything, I realized it is quite a few additions. Please have
a look at my commit message for an overview of what I have done.
The big difference is I am using inet_diag_req_v2 and I migrated a bunch more
code from socketstat (Alexey Kuznetsov, <kuznet(a)ms2.inr.ac.ru>) for building
filters.
I unfortunately haven't been working with the code for a while because I have
been travelling. I was in contact with Arnaldo in June but my changes were not
yet ready then.
I have also cc'ed tuna-devel on this email.
Feel free to contact me about anything, I am glad someone has this repository
up again. It is a great library and has a lot potential (IMHO).
Best Regards,
James
On 13.10.2014 13:34, Jiri Kastner wrote:
> of course :)
>
> do you have it somewhere in public repo?
>
> as it is dependency of tuna, can you send patches to
tuna-devel(a)lists.fedorahosted.org for review?
>
>
> On Mon, Oct 13, 2014 at 12:20:27PM +0200, James wrote:
>> Dear Jiri,
>>
>> I have been working on a project in which I used python-inet_diag for
>> the past half year in my free time.
>>
>> Since starting my project I required more functionality from the library
>> and so I added some optional parameters to the create function to allow
>> more types of filters to be used as well as some other small extensions.
>>
>> I also found a few memory leaks and fixed them.
>>
>> I would like to make a pull request so that you could review the changes.
>>
>> Is there a way this can be done?
>>
>> Thank you and best regards,
>>
>> James Hulka
>>