On 11/7/20 12:04 AM, Adam Williamson wrote:
On Fri, 2020-11-06 at 14:28 -0600, Brandon Nielsen wrote:
> I see it as fixed now too.
>
> I'm not sure that bullet really makes sense. The test cases tell you to
> download an image with the appropriate link, and the documentation
> linked to from the test case pages cover pulling an image as one of the
> steps.
That is a bit of a conflict. FWIW, I tend to prefer to not give this
kind of instruction in test cases, because in theory a test case should
be a kind of "recipe" you can run on any appropriate image. So for me a
test case could, say, list "a CoreOS image" or even "a CoreOS image
newer than XXX" (if something in the test actually needs that) as a
prerequisite, but it shouldn't specifically say stuff like "Download
and verify the latest FCOS next image". To me that's a violation of a
test case being a kind of generic recipe for testing. Specific choices
about what image to test belong to an *event* like a Test Day, not the
test case.
I can see it either way. I certainly see the logic in attaching the test
subject to the event, not the test itself. No matter what I feel like it
should be defined in one place, not both, preferably in the most easily
automated location.