On Mon, 2016-08-22 at 12:06 +0200, Petr Spacek wrote:
On 22.8.2016 11:18, Joakim Tjernlund wrote:
>
> On Mon, 2016-08-22 at 11:13 +0200, Petr Spacek wrote:
> >
> > On 22.8.2016 10:49, Ondrej Valousek wrote:
> > >
> > >
> > > I do not think this is a good patch - systematically.
> > > Maybe better approach is to rather use gethostbyname() than
gethostname().
> > > My 2 cents.
> >
> > Most importantly, this will work only for the simplest possible case where
> > host name of the client is sub-domain of AD domain.
> >
> > It will break e.g. in this scenario:
> > AD domain =
example.net.
> > Client's hostname =
myclient.branch1.example.net.
>
> No, the patch will not touch hostname if it already have a "." in it.
Yes, but it means that we are back to to manual configuration. Even worse, if
your client *is supposed* to have name "myclient.branch1.example.net." but you
did not configure it explicitly, it will create DNS records for incorrect name
"myclient.example.net.".
Sure, I just figured we should at least try to fix the common case.
As is, it is always broken(No DNS records at all)
Anyhow, I will try a FQDN hostname here and see what happens ...
Jocke