On Srp. 1, 2014, 1:22 odp., Stephen Gallagher wrote:
> I'd prefer to just drop this patch, honestly. I've never really seen an
issue with "too many comments".
I do find it annoying to have to read 3 lines instead of one, but that’s why it was a RFC;
fair enough.
- Miloslav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/47/#review198
-----------------------------------------------------------
On Srp. 1, 2014, 1:34 odp., Miloslav Trmac wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/47/
-----------------------------------------------------------
(Updated Srp. 1, 2014, 1:34 odp.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Comments to the tune of
# Check values
self.check_values(values)
IMHO only make the code less readable. Drop them.
Diffs
-----
src/rolekit/server/rolebase.py a32a95f852e00f88cae01e69d73e24cebcfe2aa8
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/47/diff/
Testing
-------
Thanks,
Miloslav Trmac