-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/47/#review139
-----------------------------------------------------------
A matter of personal style; I’d be happier with no redundant comments (and trade them for
more detailed docstrings), but I’ll go with the consensus.
- Miloslav Trmac
On Čec. 25, 2014, 9:02 odp., Miloslav Trmac wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/47/
-----------------------------------------------------------
(Updated Čec. 25, 2014, 9:02 odp.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Comments to the tune of
# Check values
self.check_values(values)
IMHO only make the code less readable. Drop them.
Diffs
-----
src/rolekit/server/rolebase.py b72071da1b0570f93dd31841747d0ea6967262da
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/47/diff/
Testing
-------
Thanks,
Miloslav Trmac