This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/47/

I can't speak for Thomas, but my approach to coding is usually to write all or most of the comments for a function first and then go back and implement the code. Sometimes this does end up with seemingly-trivial comments, but I find that too many comments are better than too few (particularly if code edits down the line make things less obvious).


- Stephen Gallagher


On July 25th, 2014, 7:02 p.m. UTC, Miloslav Trmac wrote:

Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
By Miloslav Trmac.

Updated July 25, 2014, 7:02 p.m.

Repository: rolekit

Description

Comments to the tune of
   # Check values
   self.check_values(values)

IMHO only make the code less readable.  Drop them.

Diffs

  • src/rolekit/server/rolebase.py (b72071da1b0570f93dd31841747d0ea6967262da)

View Diff