On July 28, 2014, 1:48 p.m., Stephen Gallagher wrote:
> src/rolekit/server/decorators.py, lines 43-44
>
<
http://reviewboard-fedoraserver.rhcloud.com/r/39/diff/1/?file=149#file149...
>
> I think this is backwards. Don't we want to change this to
log.exception(msg) rather than dropping the "as msg"?
Miloslav Trmac wrote:
logger.py\:Logger.exception is actually automatically extracting sys.exc_info(), and
doesn’t even accept a parameter.
My mistake; I was confusing it with python's built-in logger.
- Stephen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/39/#review148
-----------------------------------------------------------
On July 25, 2014, 6:47 p.m., Miloslav Trmac wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/39/
-----------------------------------------------------------
(Updated July 25, 2014, 6:47 p.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Remove an unused variable.
Diffs
-----
src/rolekit/server/decorators.py 213cf3c3c26dbe8c16c996bad5b3c91df644cd59
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/39/diff/
Testing
-------
Thanks,
Miloslav Trmac