This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/39/ |
On červenec 28th, 2014, 3:48 odp. CEST, Stephen Gallagher wrote:
src/rolekit/server/decorators.py (Diff revision 1) def handle_exceptions(func, *args, **kwargs):43 except Exception as msg:43 except Exception:44 log.exception()44 log.exception()I think this is backwards. Don't we want to change this to log.exception(msg) rather than dropping the "as msg"?
logger.py\:Logger.exception is actually automatically extracting sys.exc_info(), and doesn’t even accept a parameter.
- Miloslav
On červenec 25th, 2014, 8:47 odp. CEST, Miloslav Trmac wrote:
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
By Miloslav Trmac.
Updated Čec. 25, 2014, 8:47 odp.
Repository:
rolekit
Description
Diffs
|