This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/39/ |
src/rolekit/server/decorators.py (Diff revision 1) | |||
---|---|---|---|
def handle_exceptions(func, *args, **kwargs): |
|||
43 | except Exception as msg: |
43 | except Exception: |
44 | log.exception() |
44 | log.exception() |
I think this is backwards. Don't we want to change this to log.exception(msg) rather than dropping the "as msg"?
- Stephen Gallagher
On July 25th, 2014, 6:47 p.m. UTC, Miloslav Trmac wrote:
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
By Miloslav Trmac.
Updated July 25, 2014, 6:47 p.m.
Repository:
rolekit
Description
Diffs
|