-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/13/#review29
-----------------------------------------------------------
src/rolekit/server/rolebase.py
<
http://reviewboard-fedoraserver.rhcloud.com/r/13/#comment19>
In all of these methods, we don’t want the roles to copy the ~10 lines of service
handling code.
Define a
def do_start(self): raise NotImplementedError
(or name it role_start_implementation or whatever) and call that from the D-Bus
service method at the appropriate place, with exception handling.
Then roles can focus on role-specific code instead of state management.
src/rolekit/server/rolebase.py
<
http://reviewboard-fedoraserver.rhcloud.com/r/13/#comment20>
In all of these methods, we don’t want the roles to copy the ~10 lines of service
handling code.
Define a
def do_start(self): raise NotImplementedError
(or name it role_start_implementation or whatever) and call that from the D-Bus
service method at the appropriate place, with exception handling.
Then roles can focus on role-specific code instead of state management.
- Miloslav Trmac
On Čec. 17, 2014, 4:13 odp., Thomas Woerner wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/13/
-----------------------------------------------------------
(Updated Čec. 17, 2014, 4:13 odp.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
RoleBase: New methods assert_state and change_state, new state UPDATING
Diffs
-----
src/rolekit/config/__init__.py.in 4d8f53964b36feb25f97ce858cdf8eebdd0a3956
src/rolekit/errors.py 69f0fe391e97150b735564ae110146ac1badecd2
src/rolekit/server/rolebase.py 1ab6af9cd83882533017b0dd4808cc90f0f73794
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/13/diff/
Testing
-------
Thanks,
Thomas Woerner