-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/14/#review30
-----------------------------------------------------------
config/roles/testrole/role.py
<
http://reviewboard-fedoraserver.rhcloud.com/r/14/#comment21>
NAK on copying so much code, see 4: RoleBase: New methods assert_state and
change_state, new state UPDATING
config/roles/testrole/role.py
<
http://reviewboard-fedoraserver.rhcloud.com/r/14/#comment22>
NAK on copying so much code, see 4: RoleBase: New methods assert_state and
change_state, new state UPDATING
config/roles/testrole/role.py
<
http://reviewboard-fedoraserver.rhcloud.com/r/14/#comment25>
There are now two definition of get_dbus_property; AFAICS the latter one is better and
this one should go away.
config/roles/testrole/role.py
<
http://reviewboard-fedoraserver.rhcloud.com/r/14/#comment24>
Shouldn‘t this be more like the RoleBase implementation in structure?
Note that "mysetting" can't be queried using this.
config/roles/testrole/role.py
<
http://reviewboard-fedoraserver.rhcloud.com/r/14/#comment27>
s/mysetting/myownsetting/
- Miloslav Trmac
On Čec. 17, 2014, 4:13 odp., Thomas Woerner wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/14/
-----------------------------------------------------------
(Updated Čec. 17, 2014, 4:13 odp.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
Adapt testrole to latest RoleBase changes
Diffs
-----
config/roles/testrole/role.py b632321de63c331b3b3d0445d134fe1626e9944c
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/14/diff/
Testing
-------
Thanks,
Thomas Woerner