On July 17, 2014, 3:08 p.m., Miloslav Trmac wrote:
> src/rolekit/server/rolebase.py, lines 439-442
>
<
http://reviewboard-fedoraserver.rhcloud.com/r/12/diff/1/?file=64#file64li...
>
> So we will write the settings to disk _twice_ during deploy?
> (Might actually be the correct thing to do)
Thomas Woerner wrote:
Yes, we are writing twice here, becaus there is the role action after copy_defaults
and before apply_values.
Thomas Woerner wrote:
Removed the write call.
The extra write in deploy is not needed in copy_defaults, if there is an issue while
deploying, the role is again in the nascent state.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/12/#review26
-----------------------------------------------------------
On July 17, 2014, 2:12 p.m., Thomas Woerner wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/12/
-----------------------------------------------------------
(Updated July 17, 2014, 2:12 p.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
-------
RoleBase: New copy_defaults method
Diffs
-----
src/rolekit/server/rolebase.py 1ab6af9cd83882533017b0dd4808cc90f0f73794
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/12/diff/
Testing
-------
Thanks,
Thomas Woerner