On 2/17/2014 10:48 AM, Libor Zoubek wrote:
Hello,
I started to work on
https://bugzilla.redhat.com/show_bug.cgi?id=1054360 I have several
more or less cosmetic questions:
1. In order to run jboss-cli plugin needs to know AS7 native
management port and interface. I've introduced 1 pluginConfig property
<host>:<port> and added it into "operations" group. Could it be
considered as correct? I mean I could create 2 properties (similar to
what we have for http management interface host and port).
In general we use separate properties, I think, one text and one
integer. This is easier to validate. Actually, I thought the
management host and port were already connection properties? No? If not,
and if not discoverable, then perhaps the missing information should be
operation properties as opposed to connection properties (plugin config).
2. Plugin in the end runs jboss-cli process with several parameters. I
am setting ProcessExecution.setWaitForCompletion some hardcoded value
to wait for process to finish. Is it possible/recommended to fill the
value with timeout for operation defined in plugin descriptor? When
timeout ProcessExecution.setWaitForCompletion is reached, child
process is killed, I tend to set such timeout to very big number,
since I don't want child script to get interrupted in case user did
not correctly set operation timeout (he did not expect his script to
run too long).
I would suggest the timeout probably be an operation config property.
4. What would you suggest as default timeout for "executeCommands" and
"executeScript" operations? (Iam now on 60s)
5. As scripts are expected to do AS configuration changes, would you
recommend to requestAvailabilityCheck() and
requestDeferredChildResourcesDiscovery() after successfull script
execution?
I don't know but these could, I guess also be operation config properties.
Thank you