1) I noticed that datasources are created via an operation on the
datasources singleton Resource, rather than via the usual
create-child-resource mechanism. This is inconsistent with how all of
our other plugins expose child creation.
2) I like the singleton Resources for the various subsystems, because in
addition to grouping similar child services, they provide a place to put
subsystem-wide metrics, operations, and configurations. I'd rename these
to "Foo Subsystem" rather than just "foo" to stress that they are
singletons and represent subsystems (similar to what was done in the
rhq-server plugin).
3) The Resource type names in the plugin have inconsistent formats -
some are CamelCase, others are lowercase-dash-separated, and others are
Separate Capitalized Words. I think they should all be Separate
Capitalized Words, since that's what we use in almost all of our other
plugins.
4) I don't see any JMS/HornetQ related Resources. Are those on the roadmap?