modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/resource/detail/configuration/ResourceConfigurationEditView.java
| 9 +++++++++
1 file changed, 9 insertions(+)
New commits:
commit 1471bf460ce020fd91fcdf4c30f4d8e09b2640db
Author: John Mazzitelli <mazz(a)redhat.com>
Date: Fri Feb 25 16:36:20 2011 -0500
BZ 680167 - this has the bug too - after adding the refreshing stuff, it is working
better now (no dup queries)
diff --git
a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/resource/detail/configuration/ResourceConfigurationEditView.java
b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/resource/detail/configuration/ResourceConfigurationEditView.java
index 605ea83..98949f6 100644
---
a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/resource/detail/configuration/ResourceConfigurationEditView.java
+++
b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/resource/detail/configuration/ResourceConfigurationEditView.java
@@ -62,6 +62,8 @@ public class ResourceConfigurationEditView extends LocatableVLayout
implements P
private ConfigurationEditor editor;
private IButton saveButton;
+ private boolean refreshing = false;
+
public ResourceConfigurationEditView(String locatorId, ResourceComposite
resourceComposite) {
super(locatorId);
@@ -99,6 +101,11 @@ public class ResourceConfigurationEditView extends LocatableVLayout
implements P
@Override
public void refresh() {
+ if (this.refreshing) {
+ return; // we are already in the process of refreshing, don't do it
again
+ }
+
+ this.refreshing = true;
this.saveButton.disable();
GWTServiceLookup.getConfigurationService().getLatestResourceConfigurationUpdate(resource.getId(),
@@ -121,6 +128,7 @@ public class ResourceConfigurationEditView extends LocatableVLayout
implements P
editor.setReadOnly(!resourcePermission.isConfigureWrite());
addMember(editor);
markForRedraw();
+ refreshing = false;
// TODO (ips): If editor != null, use editor.reload()
instead.
}
});
@@ -128,6 +136,7 @@ public class ResourceConfigurationEditView extends LocatableVLayout
implements P
@Override
public void onFailure(Throwable caught) {
+ refreshing = false;
CoreGUI.getErrorHandler().handleError("Cannot load resource
config", caught);
}
});
Show replies by date