[rhq-project/rhq] 5ef0ba: [BZ 1144052] - On group creation error, info messa...
by Jiri Kremser
Branch: refs/heads/master
Home: https://github.com/rhq-project/rhq
Commit: 5ef0baba7378e0f805f2362bdc6c4c4d9cbce7b3
https://github.com/rhq-project/rhq/commit/5ef0baba7378e0f805f2362bdc6c4c4...
Author: Jirka Kremser <jkremser(a)redhat.com>
Date: 2014-09-30 (Tue, 30 Sep 2014)
Changed paths:
M modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/inventory/groups/wizard/GroupCreateStep.java
M modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/menu/MenuBarView.java
M modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/util/message/MessageBar.java
M modules/enterprise/gui/coregui/src/main/webapp/org.rhq.coregui.CoreGUI/sc/skins/CoreGUI/skin_styles.css
Log Message:
-----------
[BZ 1144052] - On group creation error, info messages are under fadeout window - the z-index css attribute was ignored, because there were two different so called stacking contexts. By setting the z-index to the default value (which is auto) to all related parent elements we prevent creating new stacking contexts. In other words z-index works correctly only for leave elements in the DOM tree, but if we combine different z-indices in one sub-tree it causes strange behavior.
9 years, 2 months
[rhq-project/rhq] 28a935: Bump versioning for ER04.
by spinder
Branch: refs/heads/release/jon3.3.x
Home: https://github.com/rhq-project/rhq
Commit: 28a9353d8dbc81fdf6e14e5c85e8b9b25cb7e995
https://github.com/rhq-project/rhq/commit/28a9353d8dbc81fdf6e14e5c85e8b9b...
Author: Simeon Pinder <spinder(a)redhat.com>
Date: 2014-09-30 (Tue, 30 Sep 2014)
Changed paths:
M code-coverage/pom.xml
M modules/cli-tests/pom.xml
M modules/common/ant-bundle/pom.xml
M modules/common/cassandra-auth/pom.xml
M modules/common/cassandra-ccm/cassandra-ccm-arquillian/pom.xml
M modules/common/cassandra-ccm/cassandra-ccm-core/pom.xml
M modules/common/cassandra-ccm/cassandra-ccm-maven-plugin/pom.xml
M modules/common/cassandra-ccm/cassandra-ccm-testng/pom.xml
M modules/common/cassandra-ccm/pom.xml
M modules/common/cassandra-installer/pom.xml
M modules/common/cassandra-schema/pom.xml
M modules/common/cassandra-util/pom.xml
M modules/common/drift/pom.xml
M modules/common/filetemplate-bundle/pom.xml
M modules/common/jboss-as-dmr-client/pom.xml
M modules/common/jboss-as/pom.xml
M modules/common/pom.xml
M modules/common/wfly-patch-parser/pom.xml
M modules/core/arquillian-integration/archive/pom.xml
M modules/core/arquillian-integration/container/pom.xml
M modules/core/arquillian-integration/pom.xml
M modules/core/arquillian-integration/suite-extension/pom.xml
M modules/core/arquillian-integration/test-agent-plugin/pom.xml
M modules/core/client-api/pom.xml
M modules/core/comm-api/pom.xml
M modules/core/dbutils/pom.xml
M modules/core/domain/pom.xml
M modules/core/gui/pom.xml
M modules/core/native-system/pom.xml
M modules/core/plugin-api/pom.xml
M modules/core/plugin-container-itest/pom.xml
M modules/core/plugin-container/pom.xml
M modules/core/plugin-test-api/pom.xml
M modules/core/plugin-test-util/pom.xml
M modules/core/plugin-validator/pom.xml
M modules/core/plugindoc/pom.xml
M modules/core/pom.xml
M modules/core/util/pom.xml
M modules/enterprise/agent/pom.xml
M modules/enterprise/agentupdate/pom.xml
M modules/enterprise/binding/pom.xml
M modules/enterprise/comm/pom.xml
M modules/enterprise/gui/agentupdate-war/pom.xml
M modules/enterprise/gui/content_http-war/pom.xml
M modules/enterprise/gui/coregui/pom.xml
M modules/enterprise/gui/downloads-war/pom.xml
M modules/enterprise/gui/pom.xml
M modules/enterprise/gui/portal-war/pom.xml
M modules/enterprise/gui/remote-client-war/pom.xml
M modules/enterprise/gui/remoting-war/pom.xml
M modules/enterprise/gui/rest-examples-war/pom.xml
M modules/enterprise/gui/rest-war/pom.xml
M modules/enterprise/gui/rh-access-war/pom.xml
M modules/enterprise/pom.xml
M modules/enterprise/remoting/cli/pom.xml
M modules/enterprise/remoting/client-api/pom.xml
M modules/enterprise/remoting/client-deps/pom.xml
M modules/enterprise/remoting/pom.xml
M modules/enterprise/scripting/api/pom.xml
M modules/enterprise/scripting/javascript/pom.xml
M modules/enterprise/scripting/pom.xml
M modules/enterprise/scripting/python/pom.xml
M modules/enterprise/server/appserver/pom.xml
M modules/enterprise/server/client-api/pom.xml
M modules/enterprise/server/data-migration/pom.xml
M modules/enterprise/server/ear/pom.xml
M modules/enterprise/server/embeddedagent/pom.xml
M modules/enterprise/server/installer/pom.xml
M modules/enterprise/server/itests-2/pom.xml
M modules/enterprise/server/jar/pom.xml
M modules/enterprise/server/plugins/alert-aerogear-ups/pom.xml
M modules/enterprise/server/plugins/alert-cli/pom.xml
M modules/enterprise/server/plugins/alert-email/pom.xml
M modules/enterprise/server/plugins/alert-irc/pom.xml
M modules/enterprise/server/plugins/alert-log4j/pom.xml
M modules/enterprise/server/plugins/alert-microblog/pom.xml
M modules/enterprise/server/plugins/alert-mobicents/pom.xml
M modules/enterprise/server/plugins/alert-operations/pom.xml
M modules/enterprise/server/plugins/alert-roles/pom.xml
M modules/enterprise/server/plugins/alert-snmp/pom.xml
M modules/enterprise/server/plugins/alert-subject/pom.xml
M modules/enterprise/server/plugins/alertdef-rhq/pom.xml
M modules/enterprise/server/plugins/ant-bundle/pom.xml
M modules/enterprise/server/plugins/cobbler/pom.xml
M modules/enterprise/server/plugins/disk/pom.xml
M modules/enterprise/server/plugins/drift-rhq/pom.xml
M modules/enterprise/server/plugins/filetemplate-bundle/pom.xml
M modules/enterprise/server/plugins/jboss-software/pom.xml
M modules/enterprise/server/plugins/jdr-support/pom.xml
M modules/enterprise/server/plugins/packagetype-cli/pom.xml
M modules/enterprise/server/plugins/pom.xml
M modules/enterprise/server/plugins/url/pom.xml
M modules/enterprise/server/plugins/validate-all-serverplugins/pom.xml
M modules/enterprise/server/plugins/wfly-patch-bundle/pom.xml
M modules/enterprise/server/plugins/yum/pom.xml
M modules/enterprise/server/pom.xml
M modules/enterprise/server/safe-invoker/pom.xml
M modules/enterprise/server/server-control/pom.xml
M modules/enterprise/server/server-jdr/pom.xml
M modules/enterprise/server/server-metrics/pom.xml
M modules/enterprise/server/startup-subsystem/pom.xml
M modules/enterprise/server/xml-schemas/pom.xml
M modules/helpers/bundleGen/pom.xml
M modules/helpers/jeeGen/pom.xml
M modules/helpers/metrics-simulator/pom.xml
M modules/helpers/perftest-support/pom.xml
M modules/helpers/pom.xml
M modules/helpers/rest-docs-generator/pom.xml
M modules/helpers/rtfilter-subsystem/pom.xml
M modules/helpers/rtfilter/pom.xml
M modules/integration-tests/apache-plugin-test/pom.xml
M modules/integration-tests/jndi-access/jndi-access-test/pom.xml
M modules/integration-tests/jndi-access/pom.xml
M modules/integration-tests/jndi-access/remote-server/pom.xml
M modules/integration-tests/pom.xml
M modules/integration-tests/rest-api/pom.xml
M modules/plugins/OpenShift-support/pom.xml
M modules/plugins/aliases/pom.xml
M modules/plugins/ant-bundle/pom.xml
M modules/plugins/apache/pom.xml
M modules/plugins/augeas/pom.xml
M modules/plugins/byteman/pom.xml
M modules/plugins/cassandra/pom.xml
M modules/plugins/cobbler/pom.xml
M modules/plugins/cron/pom.xml
M modules/plugins/database/pom.xml
M modules/plugins/filetemplate-bundle/pom.xml
M modules/plugins/grub/pom.xml
M modules/plugins/hadoop/pom.xml
M modules/plugins/hibernate/pom.xml
M modules/plugins/hosts/pom.xml
M modules/plugins/hudson/pom.xml
M modules/plugins/iis/pom.xml
M modules/plugins/irc/pom.xml
M modules/plugins/jboss-as-5/pom.xml
M modules/plugins/jboss-as-7-jmx/pom.xml
M modules/plugins/jboss-as-7/pom.xml
M modules/plugins/jboss-as/pom.xml
M modules/plugins/jboss-cache-v3/pom.xml
M modules/plugins/jboss-cache/pom.xml
M modules/plugins/jmx/pom.xml
M modules/plugins/kickstart/pom.xml
M modules/plugins/mod-cluster/pom.xml
M modules/plugins/mysql/pom.xml
M modules/plugins/netservices/pom.xml
M modules/plugins/noop/pom.xml
M modules/plugins/oracle/pom.xml
M modules/plugins/pattern-generator/pom.xml
M modules/plugins/perftest/pom.xml
M modules/plugins/platform/pom.xml
M modules/plugins/pom.xml
M modules/plugins/postfix/pom.xml
M modules/plugins/postgres/pom.xml
M modules/plugins/rhq-agent/pom.xml
M modules/plugins/rhq-server/pom.xml
M modules/plugins/rhq-storage/pom.xml
M modules/plugins/samba/pom.xml
M modules/plugins/script/pom.xml
M modules/plugins/script2/pom.xml
M modules/plugins/snmptrapd/pom.xml
M modules/plugins/sonarqube/pom.xml
M modules/plugins/sshd/pom.xml
M modules/plugins/sudoers/pom.xml
M modules/plugins/tomcat/pom.xml
M modules/plugins/twitter/pom.xml
M modules/plugins/validate-all-plugins/pom.xml
M modules/plugins/virt/pom.xml
M modules/pom.xml
M modules/test-utils/pom.xml
M pom.xml
Log Message:
-----------
Bump versioning for ER04.
9 years, 2 months
[rhq-project/rhq] 0d0010: Bump versioning for ER04.
by spinder
Branch: refs/heads/rc/jon3.3.0.ER04
Home: https://github.com/rhq-project/rhq
Commit: 0d00101f700991a1eca948ab97ae0682c50b54be
https://github.com/rhq-project/rhq/commit/0d00101f700991a1eca948ab97ae068...
Author: Simeon Pinder <spinder(a)redhat.com>
Date: 2014-09-30 (Tue, 30 Sep 2014)
Changed paths:
M code-coverage/pom.xml
M modules/cli-tests/pom.xml
M modules/common/ant-bundle/pom.xml
M modules/common/cassandra-auth/pom.xml
M modules/common/cassandra-ccm/cassandra-ccm-arquillian/pom.xml
M modules/common/cassandra-ccm/cassandra-ccm-core/pom.xml
M modules/common/cassandra-ccm/cassandra-ccm-maven-plugin/pom.xml
M modules/common/cassandra-ccm/cassandra-ccm-testng/pom.xml
M modules/common/cassandra-ccm/pom.xml
M modules/common/cassandra-installer/pom.xml
M modules/common/cassandra-schema/pom.xml
M modules/common/cassandra-util/pom.xml
M modules/common/drift/pom.xml
M modules/common/filetemplate-bundle/pom.xml
M modules/common/jboss-as-dmr-client/pom.xml
M modules/common/jboss-as/pom.xml
M modules/common/pom.xml
M modules/common/wfly-patch-parser/pom.xml
M modules/core/arquillian-integration/archive/pom.xml
M modules/core/arquillian-integration/container/pom.xml
M modules/core/arquillian-integration/pom.xml
M modules/core/arquillian-integration/suite-extension/pom.xml
M modules/core/arquillian-integration/test-agent-plugin/pom.xml
M modules/core/client-api/pom.xml
M modules/core/comm-api/pom.xml
M modules/core/dbutils/pom.xml
M modules/core/domain/pom.xml
M modules/core/gui/pom.xml
M modules/core/native-system/pom.xml
M modules/core/plugin-api/pom.xml
M modules/core/plugin-container-itest/pom.xml
M modules/core/plugin-container/pom.xml
M modules/core/plugin-test-api/pom.xml
M modules/core/plugin-test-util/pom.xml
M modules/core/plugin-validator/pom.xml
M modules/core/plugindoc/pom.xml
M modules/core/pom.xml
M modules/core/util/pom.xml
M modules/enterprise/agent/pom.xml
M modules/enterprise/agentupdate/pom.xml
M modules/enterprise/binding/pom.xml
M modules/enterprise/comm/pom.xml
M modules/enterprise/gui/agentupdate-war/pom.xml
M modules/enterprise/gui/content_http-war/pom.xml
M modules/enterprise/gui/coregui/pom.xml
M modules/enterprise/gui/downloads-war/pom.xml
M modules/enterprise/gui/pom.xml
M modules/enterprise/gui/portal-war/pom.xml
M modules/enterprise/gui/remote-client-war/pom.xml
M modules/enterprise/gui/remoting-war/pom.xml
M modules/enterprise/gui/rest-examples-war/pom.xml
M modules/enterprise/gui/rest-war/pom.xml
M modules/enterprise/gui/rh-access-war/pom.xml
M modules/enterprise/pom.xml
M modules/enterprise/remoting/cli/pom.xml
M modules/enterprise/remoting/client-api/pom.xml
M modules/enterprise/remoting/client-deps/pom.xml
M modules/enterprise/remoting/pom.xml
M modules/enterprise/scripting/api/pom.xml
M modules/enterprise/scripting/javascript/pom.xml
M modules/enterprise/scripting/pom.xml
M modules/enterprise/scripting/python/pom.xml
M modules/enterprise/server/appserver/pom.xml
M modules/enterprise/server/client-api/pom.xml
M modules/enterprise/server/data-migration/pom.xml
M modules/enterprise/server/ear/pom.xml
M modules/enterprise/server/embeddedagent/pom.xml
M modules/enterprise/server/installer/pom.xml
M modules/enterprise/server/itests-2/pom.xml
M modules/enterprise/server/jar/pom.xml
M modules/enterprise/server/plugins/alert-aerogear-ups/pom.xml
M modules/enterprise/server/plugins/alert-cli/pom.xml
M modules/enterprise/server/plugins/alert-email/pom.xml
M modules/enterprise/server/plugins/alert-irc/pom.xml
M modules/enterprise/server/plugins/alert-log4j/pom.xml
M modules/enterprise/server/plugins/alert-microblog/pom.xml
M modules/enterprise/server/plugins/alert-mobicents/pom.xml
M modules/enterprise/server/plugins/alert-operations/pom.xml
M modules/enterprise/server/plugins/alert-roles/pom.xml
M modules/enterprise/server/plugins/alert-snmp/pom.xml
M modules/enterprise/server/plugins/alert-subject/pom.xml
M modules/enterprise/server/plugins/alertdef-rhq/pom.xml
M modules/enterprise/server/plugins/ant-bundle/pom.xml
M modules/enterprise/server/plugins/cobbler/pom.xml
M modules/enterprise/server/plugins/disk/pom.xml
M modules/enterprise/server/plugins/drift-rhq/pom.xml
M modules/enterprise/server/plugins/filetemplate-bundle/pom.xml
M modules/enterprise/server/plugins/jboss-software/pom.xml
M modules/enterprise/server/plugins/jdr-support/pom.xml
M modules/enterprise/server/plugins/packagetype-cli/pom.xml
M modules/enterprise/server/plugins/pom.xml
M modules/enterprise/server/plugins/url/pom.xml
M modules/enterprise/server/plugins/validate-all-serverplugins/pom.xml
M modules/enterprise/server/plugins/wfly-patch-bundle/pom.xml
M modules/enterprise/server/plugins/yum/pom.xml
M modules/enterprise/server/pom.xml
M modules/enterprise/server/safe-invoker/pom.xml
M modules/enterprise/server/server-control/pom.xml
M modules/enterprise/server/server-jdr/pom.xml
M modules/enterprise/server/server-metrics/pom.xml
M modules/enterprise/server/startup-subsystem/pom.xml
M modules/enterprise/server/xml-schemas/pom.xml
M modules/helpers/bundleGen/pom.xml
M modules/helpers/jeeGen/pom.xml
M modules/helpers/metrics-simulator/pom.xml
M modules/helpers/perftest-support/pom.xml
M modules/helpers/pom.xml
M modules/helpers/rest-docs-generator/pom.xml
M modules/helpers/rtfilter-subsystem/pom.xml
M modules/helpers/rtfilter/pom.xml
M modules/integration-tests/apache-plugin-test/pom.xml
M modules/integration-tests/jndi-access/jndi-access-test/pom.xml
M modules/integration-tests/jndi-access/pom.xml
M modules/integration-tests/jndi-access/remote-server/pom.xml
M modules/integration-tests/pom.xml
M modules/integration-tests/rest-api/pom.xml
M modules/plugins/OpenShift-support/pom.xml
M modules/plugins/aliases/pom.xml
M modules/plugins/ant-bundle/pom.xml
M modules/plugins/apache/pom.xml
M modules/plugins/augeas/pom.xml
M modules/plugins/byteman/pom.xml
M modules/plugins/cassandra/pom.xml
M modules/plugins/cobbler/pom.xml
M modules/plugins/cron/pom.xml
M modules/plugins/database/pom.xml
M modules/plugins/filetemplate-bundle/pom.xml
M modules/plugins/grub/pom.xml
M modules/plugins/hadoop/pom.xml
M modules/plugins/hibernate/pom.xml
M modules/plugins/hosts/pom.xml
M modules/plugins/hudson/pom.xml
M modules/plugins/iis/pom.xml
M modules/plugins/irc/pom.xml
M modules/plugins/jboss-as-5/pom.xml
M modules/plugins/jboss-as-7-jmx/pom.xml
M modules/plugins/jboss-as-7/pom.xml
M modules/plugins/jboss-as/pom.xml
M modules/plugins/jboss-cache-v3/pom.xml
M modules/plugins/jboss-cache/pom.xml
M modules/plugins/jmx/pom.xml
M modules/plugins/kickstart/pom.xml
M modules/plugins/mod-cluster/pom.xml
M modules/plugins/mysql/pom.xml
M modules/plugins/netservices/pom.xml
M modules/plugins/noop/pom.xml
M modules/plugins/oracle/pom.xml
M modules/plugins/pattern-generator/pom.xml
M modules/plugins/perftest/pom.xml
M modules/plugins/platform/pom.xml
M modules/plugins/pom.xml
M modules/plugins/postfix/pom.xml
M modules/plugins/postgres/pom.xml
M modules/plugins/rhq-agent/pom.xml
M modules/plugins/rhq-server/pom.xml
M modules/plugins/rhq-storage/pom.xml
M modules/plugins/samba/pom.xml
M modules/plugins/script/pom.xml
M modules/plugins/script2/pom.xml
M modules/plugins/snmptrapd/pom.xml
M modules/plugins/sonarqube/pom.xml
M modules/plugins/sshd/pom.xml
M modules/plugins/sudoers/pom.xml
M modules/plugins/tomcat/pom.xml
M modules/plugins/twitter/pom.xml
M modules/plugins/validate-all-plugins/pom.xml
M modules/plugins/virt/pom.xml
M modules/pom.xml
M modules/test-utils/pom.xml
M pom.xml
Log Message:
-----------
Bump versioning for ER04.
9 years, 2 months
[rhq-project/rhq] 2c024a: [1033404] Updating Blocking Bounded Queue and Boun...
by Jay Shaughnessy
Branch: refs/heads/release/jon3.3.x
Home: https://github.com/rhq-project/rhq
Commit: 2c024accc57d27c86667fea238bb1be668f60f59
https://github.com/rhq-project/rhq/commit/2c024accc57d27c86667fea238bb1be...
Author: Jay Shaughnessy <jshaughn(a)redhat.com>
Date: 2014-09-29 (Mon, 29 Sep 2014)
Changed paths:
M modules/core/domain/intentional-api-changes-since-4.12.0.xml
M modules/core/domain/src/main/java/org/rhq/core/domain/configuration/definition/ConfigurationDefinition.java
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/ConfigurationWriteDelegate.java
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/ConnectorDiscoveryGroupValidatorComponent.java
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/CreateResourceDelegate.java
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/DatasourceComponent.java
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/TemplatedComponent.java
M modules/plugins/jboss-as-7/src/main/resources/META-INF/rhq-plugin.xml
Log Message:
-----------
[1033404] Updating Blocking Bounded Queue and Bounded Queue Thread Pools fails without core-threads value
This is a partial fix for the reported issue, and contains two associated
fixes for issues hit while working the issue.
- First, The plugin descriptor needs to specify required="false" for the
optional simples in a map of simples, otherwise they will be set to
required="true" by default (I don't know if this is true for all props, it
may be, but it was definitely true for the keepalive-time map-of-simples for
AS7 ThreadPools). Otherwise values will be expected. Fix this because this
prevents the create child from working unless you sepcify keepalive-time.
- Second, a map-of-Simples in a resource configuration always generates
a Map in the Configuration, even if the Map is "empty" because the Simples
are all "unset" (set to null values). This was not being handled well in
the create resource code, where an unset map should be ignored as if the
entire PropertyMap is "unset". Note that an empty MapProperty in a
configuration update should be processed, because we may be trying to unset
one or more of Simples that currently have a value.
- Third, to work around the fact that AS can't currently handle an undefine
(i.e update to null) of core-threads (and possibly other attributes), add
an optimization such that we don't try to update undefined (null)
attributes to be undefined, since they are undefined already.
- There was another issue in that the plugin code was actually modifying
the ConfigurationDefinition held in the ResourceContext (which is a
weakness in our design that we even let that happen). Changed to use a
copy of the ConfigurationDefinition (and added a copy() method in the
Entity, migrating it from plugin code where it was previously defined).
So, the partial fix is that we can now create with empty maps and we can
update without setting core-threads to a value, leaving it unset. But once
set core-threads can *not* be unset until the AS bug is fixed and the
fixed version is a version being managed.
(cherry picked from commit e7a641350e155c7cd6ed6c566491ef425aeee3e2)
Signed-off-by: Jay Shaughnessy <jshaughn(a)redhat.com>
Commit: eb0eee822e93b5a4820e5c411639dc737004c72a
https://github.com/rhq-project/rhq/commit/eb0eee822e93b5a4820e5c411639dc7...
Author: Jay Shaughnessy <jshaughn(a)redhat.com>
Date: 2014-09-30 (Tue, 30 Sep 2014)
Changed paths:
M modules/enterprise/gui/coregui/src/main/java/org/rhq/coregui/client/components/configuration/ConfigurationEditor.java
Log Message:
-----------
[822173, 1146846] Broken layout on JBossAS7 resource configuration page
Work done for Bug 1144459 was unknowingly trying to fix the problem
reported in Bug 822173. It succeeded in fixing the column header issue
but caused the regression reported in Bug 1146846. This (finally) seems
to have fixed the problems for all three BZs, working around the Smartgwt
bug at the root of all of the problems.
(cherry picked from commit 29368f3515fc3cf00b545ad56c83e08e9dc6fcf6)
Signed-off-by: Jay Shaughnessy <jshaughn(a)redhat.com>
Compare: https://github.com/rhq-project/rhq/compare/b3133b41dce8...eb0eee822e93
9 years, 2 months
[rhq-project/rhq] e7a641: [1033404] Updating Blocking Bounded Queue and Boun...
by Jay Shaughnessy
Branch: refs/heads/master
Home: https://github.com/rhq-project/rhq
Commit: e7a641350e155c7cd6ed6c566491ef425aeee3e2
https://github.com/rhq-project/rhq/commit/e7a641350e155c7cd6ed6c566491ef4...
Author: Jay Shaughnessy <jshaughn(a)redhat.com>
Date: 2014-09-29 (Mon, 29 Sep 2014)
Changed paths:
M modules/core/domain/intentional-api-changes-since-4.12.0.xml
M modules/core/domain/src/main/java/org/rhq/core/domain/configuration/definition/ConfigurationDefinition.java
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/ConfigurationWriteDelegate.java
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/ConnectorDiscoveryGroupValidatorComponent.java
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/CreateResourceDelegate.java
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/DatasourceComponent.java
M modules/plugins/jboss-as-7/src/main/java/org/rhq/modules/plugins/jbossas7/TemplatedComponent.java
M modules/plugins/jboss-as-7/src/main/resources/META-INF/rhq-plugin.xml
Log Message:
-----------
[1033404] Updating Blocking Bounded Queue and Bounded Queue Thread Pools fails without core-threads value
This is a partial fix for the reported issue, and contains two associated
fixes for issues hit while working the issue.
- First, The plugin descriptor needs to specify required="false" for the
optional simples in a map of simples, otherwise they will be set to
required="true" by default (I don't know if this is true for all props, it
may be, but it was definitely true for the keepalive-time map-of-simples for
AS7 ThreadPools). Otherwise values will be expected. Fix this because this
prevents the create child from working unless you sepcify keepalive-time.
- Second, a map-of-Simples in a resource configuration always generates
a Map in the Configuration, even if the Map is "empty" because the Simples
are all "unset" (set to null values). This was not being handled well in
the create resource code, where an unset map should be ignored as if the
entire PropertyMap is "unset". Note that an empty MapProperty in a
configuration update should be processed, because we may be trying to unset
one or more of Simples that currently have a value.
- Third, to work around the fact that AS can't currently handle an undefine
(i.e update to null) of core-threads (and possibly other attributes), add
an optimization such that we don't try to update undefined (null)
attributes to be undefined, since they are undefined already.
- There was another issue in that the plugin code was actually modifying
the ConfigurationDefinition held in the ResourceContext (which is a
weakness in our design that we even let that happen). Changed to use a
copy of the ConfigurationDefinition (and added a copy() method in the
Entity, migrating it from plugin code where it was previously defined).
So, the partial fix is that we can now create with empty maps and we can
update without setting core-threads to a value, leaving it unset. But once
set core-threads can *not* be unset until the AS bug is fixed and the
fixed version is a version being managed.
Commit: 53fd5a6d07629dc1216033d6b26eff3be6a156ff
https://github.com/rhq-project/rhq/commit/53fd5a6d07629dc1216033d6b26eff3...
Author: Jay Shaughnessy <jshaughn(a)redhat.com>
Date: 2014-09-29 (Mon, 29 Sep 2014)
Changed paths:
M .classpath
Log Message:
-----------
eclipse classpath updates
Compare: https://github.com/rhq-project/rhq/compare/5fec5167ff76...53fd5a6d0762
9 years, 2 months