modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/groups/detail/inventory/CurrentGroupPluginConfigurationView.java
| 8 ++++++++
1 file changed, 8 insertions(+)
New commits:
commit 53bd82755c6fb065b66f6980e2f59459119f5e4e
Author: John Mazzitelli <mazz(a)redhat.com>
Date: Fri Feb 25 16:18:22 2011 -0500
BZ 680167 - this follows the same pattern as did GroupResourceConfigurationEditView
so I'm adding the "refreshing" check. however, in my testing, even
though it used
the same pattern I did not see the same double querying. I don't know why this
is different, but to prevent this from happening anyway, I added the
refreshing check, it can't hurt.
diff --git
a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/groups/detail/inventory/CurrentGroupPluginConfigurationView.java
b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/groups/detail/inventory/CurrentGroupPluginConfigurationView.java
index e33773c..9a124e5 100644
---
a/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/groups/detail/inventory/CurrentGroupPluginConfigurationView.java
+++
b/modules/enterprise/gui/coregui/src/main/java/org/rhq/enterprise/gui/coregui/client/inventory/groups/detail/inventory/CurrentGroupPluginConfigurationView.java
@@ -73,6 +73,8 @@ public class CurrentGroupPluginConfigurationView extends
LocatableVLayout implem
private ConfigurationEditor editor;
private IButton saveButton;
+ private boolean refreshing = false;
+
public CurrentGroupPluginConfigurationView(String locatorId, ResourceGroupComposite
groupComposite) {
super(locatorId);
@@ -112,6 +114,11 @@ public class CurrentGroupPluginConfigurationView extends
LocatableVLayout implem
@Override
public void refresh() {
+ if (this.refreshing) {
+ return; // we are already in the process of refreshing, don't do it
again
+ }
+
+ this.refreshing = true;
this.saveButton.disable();
if (editor != null) {
editor.destroy();
@@ -132,6 +139,7 @@ public class CurrentGroupPluginConfigurationView extends
LocatableVLayout implem
this.editor.addPropertyValueChangeListener(this);
this.editor.setReadOnly(!this.resourcePermission.isConfigureWrite());
addMember(this.editor);
+ this.refreshing = false;
}
}
Show replies by date