Hello everyone :) I hope everyone is doing good in this pandemic. Myself Kunal Prakash. 2nd year student from NIT Patna. I am experienced with Javascript, React, Redux, CSS. I come across "Improve Fedora QA Dashboard" project. I really liked the project and want to contribute to it. Thank you.
Hi Kunal,
thanks for showing interest in our project, I see you already found our pagure repo and an issue you like to work on. I'll assign that issue to you. For any more questions feel free to post here or contact me directly via email lbrabec@redhat.com
L.
On Tue, Mar 30, 2021 at 7:36 AM KUNAL PRAKASH kunalprakash1309@gmail.com wrote:
Hello everyone :) I hope everyone is doing good in this pandemic. Myself Kunal Prakash. 2nd year student from NIT Patna. I am experienced with Javascript, React, Redux, CSS. I come across "Improve Fedora QA Dashboard" project. I really liked the project and want to contribute to it. Thank you. _______________________________________________ qa-devel mailing list -- qa-devel@lists.fedoraproject.org To unsubscribe send an email to qa-devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/qa-devel@lists.fedoraproject.o... Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Hello Lukas Brabec,
I was in quarantine for 12 days because I was tested COVID positive. Due to which I was unable to contribute to this project. But from now I want to contribute to the project consistently.
I like to solve the issue which shows on console tab in developers tool.
Hi Kunal,
good to hear you made it through C19.
Feel free to solve the issue and open pull request when you are done. Currently we don't assign any issues and we don't merge pull requests. In this way, everyone can work on any issue and we can compare the communication, code in pull requests, etc...
L.
On Tue, Apr 13, 2021 at 8:47 PM KUNAL PRAKASH kunalprakash1309@gmail.com wrote:
Hello Lukas Brabec,
I was in quarantine for 12 days because I was tested COVID positive. Due to which I was unable to contribute to this project. But from now I want to contribute to the project consistently.
I like to solve the issue which shows on console tab in developers tool. _______________________________________________ qa-devel mailing list -- qa-devel@lists.fedoraproject.org To unsubscribe send an email to qa-devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/qa-devel@lists.fedoraproject.o... Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Hello again Lukas Brabec, I have one query that despite of having state store which contain all the state. Why we are passing state as a props to component like Timeline.js, Event.js etc. Why don't we use mapStateToProps for directly using the particular state that component want to use.
There really isn't a reason, it is a quick and dirty code I did to have a proof of concept. Feel free to fix it.
L.
On Wed, Apr 21, 2021 at 10:52 AM KUNAL PRAKASH kunalprakash1309@gmail.com wrote:
Hello again Lukas Brabec, I have one query that despite of having state store which contain all the state. Why we are passing state as a props to component like Timeline.js, Event.js etc. Why don't we use mapStateToProps for directly using the particular state that component want to use. _______________________________________________ qa-devel mailing list -- qa-devel@lists.fedoraproject.org To unsubscribe send an email to qa-devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/qa-devel@lists.fedoraproject.o... Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Hello Lukas. I have noticed that spinner component run when we are calling LOAD_DATA for LandingPage component but not when we are loading LOAD_WIZARD_DATA for WIZARD component. I like to implement this feature.
But I have some problem because we are using this.props.stable === 0 for LandingPage component. And there is no such state to handle for WIZARD component.
Shall I add new state or add Higher order component?
qa-devel@lists.fedoraproject.org