On 03/25/2015 03:26 PM, Brian Bouterse wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Thanks for the info. I just submitted my patch as described in
HACKING. It includes:
* Explicit keyword params for the function signatures.
* A new update_external_tracker method
* The rest of the params that add and remove support
* I extended build_external_tracker_boolean_query to support all the
params
* I rewrote the functional tests for add/update/remove and also the
query support. I added a lot of assertions (this took the longest).
Feel free to send feedback, adjustments, or merge it in! If it gets
merged can someone let me know? It's my first patch so I'm not sure if
I'll get notified.
Sorry, forgot to reply to this.
Your patch didn't make it to the mailing list though, see the archives:
https://lists.fedorahosted.org/pipermail/python-bugzilla/2015-March/threa...
Or did you submit it somewhere else?
If you're having trouble with git send-email, it's okay to send the git
format-patch file as a regular attachment.
Unrelated to my tests some of the rw_functional tests are broken. I
think one is due to my user not having enough perms (which I don't
need), but the second (tests.rw_functional.RHPartnerTest) looks like a
legitimate failure. See the failures here:
http://fpaste.org/202891/14273114/
I don't plan on fixing those, but someone should.
Ah those are probably errors related to not being in the fedora developer
group. I'll have to come up with some check for it, but indeed you don't have
to worry about it.
- Cole