On Wed, 2020-05-06 at 17:41 +0300, Dmitry V. Levin wrote:
On Mon, May 04, 2020 at 01:56:57AM +0300, Dmitry V. Levin wrote:
> Our modules are very inconsistent in the way they use the value
> returned
> by pam_get_user. They have to be fixed, but pam_get_user has to be
> fixed
> first.
>
> I've also pushed the series to ldv/pam_get_user branch.
>
> Dmitry V. Levin (4):
> pam_get_user: consistently return PAM_SYSTEM_ERR if user
> specified a NULL pointer
> man: document other valid pam_get_user return values
> pam_get_user: filter conversation function return values
> pam_get_user: do not override valid values returned by the
> conversation function
>
> doc/man/pam_get_user.3.xml | 25 +++++++++++++++
> libpam/pam_item.c | 62 +++++++++++++++++++++++-----------
> ----
> 2 files changed, 63 insertions(+), 24 deletions(-)
Any comments so far?
This patchset looks good to me. Please commit.
I'll look at the pam_localuser rewrite as soon as I find some time.
--
Tomáš Mráz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb
[You'll know whether the road is wrong if you carefully listen to your
conscience.]