[linux-pam] #35: 'logic list' format unexplained in group.conf manpage
by fedora-badges
#35: 'logic list' format unexplained in group.conf manpage
--------------------------+-----------------------------------
Reporter: robinmiller | Owner: pam-developers@…
Type: defect | Status: new
Priority: minor | Component: documentation
Version: | Keywords: group.conf logic list
Blocked By: | Blocking:
--------------------------+-----------------------------------
The group.conf manpage refers to a 'logic list' several times as the way
to specify multiple ttys, users, etc, but does not give a clear example or
describe the syntax required.
After some fruitless searching and then trial and error, I discovered that
the format is:
{{{
item1 | item2 | item3
}}}
I think it would be a big help to users to make this clear in the man
page, either by describing the syntax or by giving a clear example in the
examples section (there is a convoluted example using &, but I don't think
this is obvious at first). For example, the example:
{{{
Running 'xsh' on tty* (any ttyXXX device), the user 'sword' is given
access to games (through membership of the floppy group) after work hours.
xsh; tty* ;sword;!Wk0900-1800;games, sound
}}}
Could be made into:
{{{
Running 'xsh' on tty* (any ttyXXX device), the users 'sword' and 'pike'
are given access to games (through membership of the floppy group) after
work hours.
xsh; tty* ; sword | pike ;!Wk0900-1800;games, sound
}}}
That small change alone would have saved me an hour. Perhaps the term
'logic list' is a well known format to some, but I don't think to many.
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/35>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
9 years, 1 month
[linux-pam] #33: pam_timestamp: timestampdir option not documented properly
by fedora-badges
#33: pam_timestamp: timestampdir option not documented properly
---------------------+------------------------------
Reporter: thoger | Owner: pam-developers@…
Type: defect | Status: new
Priority: minor | Component: modules
Version: | Keywords:
Blocked By: | Blocking:
---------------------+------------------------------
pam_timestamp module supports `timestampdir` option, which is not properly
mentioned in the documentation / man page for the module. The only
mention is:
When an application opens a session using
<emphasis>pam_timestamp</emphasis>,
a timestamp file is created in the <emphasis>timestampdir</emphasis>
directory
for the user.
but it is not listed in SYNOPSIS or OPTIONS sections.
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/33>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
9 years, 1 month
[linux-pam] #36: pam_fail_delay() inconsistent delay distribution
by fedora-badges
#36: pam_fail_delay() inconsistent delay distribution
---------------------+------------------------------
Reporter: szidek | Owner: pam-developers@…
Type: defect | Status: new
Priority: major | Component: library
Version: 1.1.x | Keywords:
Blocked By: | Blocking:
---------------------+------------------------------
Man page says: Should pam_authenticate(3) fail, the failing return to the
application is delayed by an amount of time randomly distributed (by up to
25%) about this longest value.
However, code uses distribution 50%.
(Comments also say 25%.)
I think these values should be consistent.
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/36>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
9 years, 1 month
[PATCH v2 1/3] build-sys: rename configure.in to configure.ac
by Ronny Chevalier
aclocal: warning: autoconf input should be named 'configure.ac', not 'configure.in'
* configure.in: Renamed to configure.ac
---
configure.in => configure.ac | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename configure.in => configure.ac (100%)
diff --git a/configure.in b/configure.ac
similarity index 100%
rename from configure.in
rename to configure.ac
--
2.1.3
9 years, 3 months
[PATCH] build: raise gettext version requirement
by Dmitry V. Levin
Raise gettext requirement to the latest oldstable version 0.18.3.
This fixes the following automake warning:
configure.ac:581: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged.
configure.ac:581: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead,
configure.ac:581: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files.
* configure.ac (AM_GNU_GETTEXT_VERSION): Raise from 0.15 to 0.18.3.
* po/Makevars: Update from gettext-0.18.3.
---
gettext switched from AM_PROG_MKDIR_P to AC_PROG_MKDIR_P in 0.18.2 that
was released 2 years ago. 0.18.3 was released 1.5 years ago. The latest
gettext version released from 0.18.3 branch (1 year ago) is 0.18.3.2,
it's ABI version is 0.18.3. The latest gettext stable release is 0.19.4.
That is, we can safely assume that gettext >= 0.18.3 is available
for everybody who builds Linux-PAM.git.
configure.ac | 2 +-
po/Makevars | 12 ++++++++++++
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index cbe5d71..47d254b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -577,7 +577,7 @@ AM_CONDITIONAL(ENABLE_REGENERATE_MAN, test x$enable_docu != xno)
AM_CONDITIONAL(ENABLE_GENERATE_PDF, test ! -z "$FO2PDF")
-AM_GNU_GETTEXT_VERSION([0.15])
+AM_GNU_GETTEXT_VERSION([0.18.3])
AM_GNU_GETTEXT([external])
AC_CHECK_FUNCS(dngettext)
diff --git a/po/Makevars b/po/Makevars
index c152efd..2e0a6ca 100644
--- a/po/Makevars
+++ b/po/Makevars
@@ -39,3 +39,15 @@ MSGID_BUGS_ADDRESS = http://sourceforge.net/projects/pam
# This is the list of locale categories, beyond LC_MESSAGES, for which the
# message catalogs shall be used. It is usually empty.
EXTRA_LOCALE_CATEGORIES =
+
+# This tells whether the $(DOMAIN).pot file contains messages with an 'msgctxt'
+# context. Possible values are "yes" and "no". Set this to yes if the
+# package uses functions taking also a message context, like pgettext(), or
+# if in $(XGETTEXT_OPTIONS) you define keywords with a context argument.
+USE_MSGCTXT = no
+
+# These options get passed to msgmerge.
+# Useful options are in particular:
+# --previous to keep previous msgids of translated messages,
+# --quiet to reduce the verbosity.
+MSGMERGE_OPTIONS =
--
ldv
9 years, 3 months
[PATCH] libpam: Only print "Password change aborted" when it's true.
by Luke Shumaker
pam_get_authtok() may be used any time that a password needs to be entered,
unlike pam_get_authtok_{no,}verify(), which may only be used when
changing a password; yet when the user aborts, it prints "Password change
aborted." whether or not that was the operation being performed.
This bug was non-obvious because none of the modules distributed with
Linux-PAM use it for anything but changing passwords; pam_unix has its
own utility function that it uses instead. As an example, the
nss-pam-ldapd package uses it in pam_sm_authenticate().
libpam/pam_get_authtok.c (pam_get_authtok_internal): check that the
password is trying to be changed before printing a message about the
password change being aborted.
---
libpam/pam_get_authtok.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libpam/pam_get_authtok.c b/libpam/pam_get_authtok.c
index 31bb162..663f1f3 100644
--- a/libpam/pam_get_authtok.c
+++ b/libpam/pam_get_authtok.c
@@ -151,8 +151,9 @@ pam_get_authtok_internal (pam_handle_t *pamh, int item,
if (retval != PAM_SUCCESS || resp[0] == NULL ||
(chpass > 1 && resp[1] == NULL))
{
- /* We want to abort the password change */
- pam_error (pamh, _("Password change aborted."));
+ /* We want to abort */
+ if (chpass)
+ pam_error (pamh, _("Password change aborted."));
return PAM_AUTHTOK_ERR;
}
--
2.2.0
9 years, 4 months