[linux-pam] #4: [PATCH] po/ja.po: Fix some wrong translations and so on
by fedora-badges
#4: [PATCH] po/ja.po: Fix some wrong translations and so on
--------------------+-------------------------------------------------------
Reporter: fumiyas | Owner: pam-developers(a)lists.fedorahosted.org
Type: defect | Status: new
Priority: major | Component: library
Version: 1.1.x | Keywords: l10n
--------------------+-------------------------------------------------------
I've updated po/ja.po to fix some wrong translations and so on.
Please see and commit the attached patch to master repository if you feel
good.
Should I contact the original translator (Kiyoto Hashida
<khashida(a)redhat.com>) to check and confirm this patch?
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/4>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
9 years
[linux-pam] #20: compilation warnings
by fedora-badges
#20: compilation warnings
---------------------+------------------------------
Reporter: mirraz | Owner: pam-developers@…
Type: defect | Status: new
Priority: minor | Component: library
Version: | Keywords:
Blocked By: | Blocking:
---------------------+------------------------------
Building pam-1.1.6 I'v got this compilation warnings:
{{{
md5.c:145:2: warning: dereferencing type-punned pointer will break strict-
aliasing rules [-Wstrict-aliasing]
md5.c:146:2: warning: dereferencing type-punned pointer will break strict-
aliasing rules [-Wstrict-aliasing]
misc_conv.c:213:22: warning: the address of ‘line’ will always evaluate as
‘true’ [-Waddress]
misc_conv.c:325:15: warning: the address of ‘binary_prompt’ will always
evaluate as ‘true’ [-Waddress]
}}}
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/20>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
9 years, 3 months
[linux-pam] #9: Allow pam_lastlog to write to utmp as an option
by fedora-badges
#9: Allow pam_lastlog to write to utmp as an option
-------------------------+-------------------------------------------------
Reporter: | Owner: pam-developers@…
shadowkyogre | Status: new
Type: | Component: modules
enhancement | Keywords: pam_lastlog utmp update patch
Priority: major | prototype
Version: 1.1.x | Blocking:
Blocked By: |
-------------------------+-------------------------------------------------
The following patch for pam_lastlog allows it to write to utmp as well as
wtmp. Part of the code is from xorg-sessreg to help make a utmp entry. I
only tested this on my desktop, which is running Arch Linux, so some
modifications may need to be made in order to make it more portable.
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/9>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
9 years, 3 months
[linux-pam] #5: multiple pam_namespace unmount problems
by fedora-badges
#5: multiple pam_namespace unmount problems
-----------------------------+------------------------------
Reporter: andersblomdell | Owner: pam-developers@…
Type: defect | Status: new
Priority: major | Component: library
Version: 1.1.x | Keywords:
Blocked By: | Blocking:
-----------------------------+------------------------------
This is essentially a short version of the bug in:
http://bugzilla.redhat.com/show_bug.cgi?id=755216
Essentially pam_namespace (1.1.5) suffers the following problems:
1. The (bind) mounts done in the new namespace is visible in the
original namespace (Error "too many levels of symbolic links").
2. At pam_namespace exit, the original mounting is restored for any
remaining child processes (daemons), which is a security problem.
Patch is attached
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/5>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
10 years, 5 months
[linux-pam] #22: pam_mkhomedir uses user alias username instead of canonical name when creating home directories
by fedora-badges
#22: pam_mkhomedir uses user alias username instead of canonical name when
creating home directories
-------------------------+-------------------------------------------------
Reporter: | Owner: pam-developers@…
musicalvegan0 | Status: new
Type: defect | Component: modules
Priority: major | Keywords: sssd, ipa, active directory,
Version: 1.1.x | mkhomedir
Blocked By: | Blocking:
-------------------------+-------------------------------------------------
When logging in with an "alias" for the first time, mkhomedir will take
the alias of the user instead of looking up the canonical name associated
with the alias. This can lead to the creation of the wrong home directory
and ends up putting the user somewhere other than their home directory.
Please see this listserv archive for additional context:
https://lists.fedorahosted.org/pipermail/sssd-
users/2013-October/001056.html
Steps to reproduce:
1. Create a user account with an alias on a directory server.
2. Configure PAM to authenticate against the directory server.
3. Configure PAM with pam_mkhomedir.so so home directories are created for
first time logins.
4. Login for the first time with the user's alias.
What is expected to happen:
The proper home directory is created and the user is chdir-ed into it.
What actually happens:
This can vary. In my case, the user's home directory path is not retrieved
from the directory server and a fallback home directory is erroneously
created. The user is not started in the proper home directory.
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/22>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
10 years, 5 months
[linux-pam] #19: logger message uses uninitialized char buffer in group_match() of pam_access.c
by fedora-badges
#19: logger message uses uninitialized char buffer in group_match() of
pam_access.c
-----------------------+------------------------------
Reporter: nickfelt | Owner: pam-developers@…
Type: defect | Status: new
Priority: minor | Component: modules
Version: 1.1.x | Keywords:
Blocked By: | Blocking:
-----------------------+------------------------------
I was debugging my configuration of the pam_access module and noticed some
strange behavior in the debug-level logging messages, which I traced to
the `group_match()` function:
[https://git.fedorahosted.org/cgit/linux-
pam.git/tree/modules/pam_access/pam_access.c#n566]
On line 576 it writes a log message using the `grptok` char buffer, which
has just been declared and not initialized. Presumably the logging call
should either use `tok` instead to print the group name in parentheses, or
the logging call should be moved below the `strncpy()` call, at which
point `grptok` is valid, to print the group name without parentheses. I
would've attached a patch but I wasn't sure which solution was preferable.
At least on my machine, the current code prints an empty string on the
first call to `group_match` and then on each successive call it prints the
value of grptok corresponding to the previous call to `group_match` that
is still in the buffer. I've attached my test-case
`/etc/security/access.conf` and the logging output I saw.
--
Ticket URL: <https://fedorahosted.org/linux-pam/ticket/19>
linux-pam <http://fedorahosted.org/linux-pam>
The Linux-PAM (Pluggable Authentication Modules) project
10 years, 5 months
[PATCH] Fix pam_tty_audit log_passwd support and regression #2.
by Richard Guy Briggs
modules/pam_tty_audit/pam_tty_audit.c: Deal with mismatched message size.
(nl_recv): Pad result with zeros if message is short from older kernel.
Signed-off-by: Richard Guy Briggs <rgb(a)redhat.com>
---
modules/pam_tty_audit/pam_tty_audit.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/modules/pam_tty_audit/pam_tty_audit.c b/modules/pam_tty_audit/pam_tty_audit.c
index cc86255..a1a3aa4 100644
--- a/modules/pam_tty_audit/pam_tty_audit.c
+++ b/modules/pam_tty_audit/pam_tty_audit.c
@@ -109,7 +109,7 @@ nl_recv (int fd, unsigned type, void *buf, size_t size)
struct msghdr msg;
struct nlmsghdr nlm;
struct iovec iov[2];
- ssize_t res;
+ ssize_t res, resdiff;
again:
iov[0].iov_base = &nlm;
@@ -161,12 +161,17 @@ nl_recv (int fd, unsigned type, void *buf, size_t size)
res = recvmsg (fd, &msg, 0);
if (res == -1)
return -1;
- if ((size_t)res != NLMSG_LENGTH (size)
+ resdiff = NLMSG_LENGTH(size) - (size_t)res;
+ if (resdiff < 0
|| nlm.nlmsg_type != type)
{
errno = EIO;
return -1;
}
+ else if (resdiff > 0)
+ {
+ memset(buf[size - resdiff], 0, resdiff);
+ }
return 0;
}
--
1.7.1
10 years, 8 months
pam_tty_audit: Allow for backwards runtime compatibility with old kernels
by Tomas Mraz
Hi,
this patch by Richard Briggs adds backwards compatibility with old
kernels that do not support the log_password functionality if you
compile PAM against new kernel headers.
diff --git a/modules/pam_tty_audit/pam_tty_audit.c b/modules/pam_tty_audit/pam_tty_audit.c
index cc86255..a1a3aa4 100644
--- a/modules/pam_tty_audit/pam_tty_audit.c
+++ b/modules/pam_tty_audit/pam_tty_audit.c
@@ -109,7 +109,7 @@ nl_recv (int fd, unsigned type, void *buf, size_t size)
struct msghdr msg;
struct nlmsghdr nlm;
struct iovec iov[2];
- ssize_t res;
+ ssize_t res, resdiff;
again:
iov[0].iov_base = &nlm;
@@ -161,12 +161,17 @@ nl_recv (int fd, unsigned type, void *buf, size_t size)
res = recvmsg (fd, &msg, 0);
if (res == -1)
return -1;
- if ((size_t)res != NLMSG_LENGTH (size)
+ resdiff = NLMSG_LENGTH(size) - (size_t)res;
+ if (resdiff < 0
|| nlm.nlmsg_type != type)
{
errno = EIO;
return -1;
}
+ else if (resdiff > 0)
+ {
+ memset(buf[size - resdiff], 0, resdiff);
+ }
return 0;
}
OK to commit?
--
Tomas Mraz
No matter how far down the wrong road you've gone, turn back.
Turkish proverb
(You'll never know whether the road is wrong though.)
10 years, 8 months