Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-boxgrinder-build-rpm-based-os-plugin - Files required to build appliances based on RPMs
https://bugzilla.redhat.com/show_bug.cgi?id=652403
Summary: Review Request: rubygem-boxgrinder-build-rpm-based-os-plugin - Files required to build appliances based on RPMs Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mgoldman@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinde... SRPM URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinde... Description:
BoxGrinder Build (http://www.jboss.org/boxgrinder) to Fedora. BoxGrinder is a command line tool for building appliances (virtual machines) to various platforms (KVM, Xen, VMware, EC2).
This package contains files required to build appliances based on RPMs.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
Garrett Holmstrom gholms@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gholms@fedoraproject.org Depends on| |652400
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
Garrett Holmstrom gholms@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |652406
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
--- Comment #1 from Marek Goldmann mgoldman@redhat.com 2010-11-23 11:01:29 EST --- Below updated spec files:
Spec URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinde... SRPM URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinde...
We need to wait for rubygem-boxgrinder-build (BZ#652400) to be pushed to rawhide to build it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
--- Comment #2 from Marek Goldmann mgoldman@redhat.com 2010-11-24 12:55:00 EST --- Updated files:
Spec URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinde... SRPM URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinde...
Scratch build on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2621826
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Flag| |fedora-review?
--- Comment #3 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-11-26 12:49:42 EST --- Some notes:
! Source --------------------------------------------------------------- a440ee244f272cfa1a2ef680b8beb199 Downloaded/boxgrinder-build-rpm-based-os-plugin-0.0.8.gem e6d7d2503e9655bb36f73a1ff881cea4 rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-2.fc15.src/boxgrinder-build-rpm-based-os-plugin-0.0.8.gem --------------------------------------------------------------- - The source in your srpm does not match the one I could download from the URL written as Source0. Would you explain why?
! No longer needed stuff - %clean section is no longer needed on Fedora: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
* rpmlint issue --------------------------------------------------------------- rubygem-boxgrinder-build-rpm-based-os-plugin.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/boxgrinder-build-rpm-based-os-plugin-0.0.8/lib/boxgrinder-build-rpm-based-os-plugin/src/motd.init 0664L /bin/sh --------------------------------------------------------------- - This warning comes because this script does not have executable permission while the script has shebang. While I think this script need not have executable permission because this file seems something like a template, however I think 0644 permission is more proper.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
--- Comment #4 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-11-26 12:50:22 EST --- By the way I would appreciate it if you have some time to review my review request (bug 657591)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
--- Comment #5 from Marek Goldmann mgoldman@redhat.com 2010-11-26 13:03:32 EST --- (In reply to comment #3)
Some notes:
! Source
a440ee244f272cfa1a2ef680b8beb199 Downloaded/boxgrinder-build-rpm-based-os-plugin-0.0.8.gem e6d7d2503e9655bb36f73a1ff881cea4 rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-2.fc15.src/boxgrinder-build-rpm-based-os-plugin-0.0.8.gem
- The source in your srpm does not match the one I could download from the URL written as Source0. Would you explain why?
The src.rpm uses a regenerated gem, but from the same source as pushed to rubygems.org. When checking into git I'm overriding the .gem with the proper version (from rubygems.org). Currently - all my src.rpm have this issue. I'll change the way I build my src.rpm for review for the next submissions.
Sorry for confusion!
! No longer needed stuff
- %clean section is no longer needed on Fedora: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
Going to remove it, thanks!
- rpmlint issue
rubygem-boxgrinder-build-rpm-based-os-plugin.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/boxgrinder-build-rpm-based-os-plugin-0.0.8/lib/boxgrinder-build-rpm-based-os-plugin/src/motd.init 0664L /bin/sh
- This warning comes because this script does not have executable permission while the script has shebang. While I think this script need not have
executable permission because this file seems something like a template, however I think 0644 permission is more proper.
Yes this is just a template.
I'll post updated spec and review your package shortly.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
--- Comment #6 from Marek Goldmann mgoldman@redhat.com 2010-11-26 15:16:03 EST --- Updated files:
Spec URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinde... SRPM URL: http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinde...
Koji scratch build for Rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2628716
Changelog:
* Fri Nov 26 2010 mgoldman@redhat.com - 0.0.8-3 - Removed clean section, updated URL, fixed attr for motd.init file
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #7 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-11-26 16:13:49 EST --- No blockers, approving.
------------------------------------------------------------------ This package (rubygem-boxgrider-build-rpm-based-os-plugin) is APPROVED by mtasaka ------------------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #8 from Marek Goldmann mgoldman@redhat.com 2010-11-27 02:44:26 EST --- Thanks!
New Package SCM Request ======================= Package Name: rubygem-boxgrider-build-rpm-based-os-plugin Short Description: Files required to build appliances based on RPMs Owners: goldmann Branches: f13 f14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
--- Comment #9 from Jason Tibbitts tibbs@math.uh.edu 2010-11-29 12:01:19 EST --- The requested package name does not match the name in the ticket summary. Please either correct the ticket summary or submit a new SVM request and re-raise the fedora-cvs flag.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #10 from Marek Goldmann mgoldman@redhat.com 2010-11-29 12:22:55 EST --- Right, I ate one letter, sorry for that!
New Package SCM Request ======================= Package Name: rubygem-boxgrinder-build-rpm-based-os-plugin Short Description: Files required to build appliances based on RPMs Owners: goldmann Branches: f13 f14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
--- Comment #11 from Jason Tibbitts tibbs@math.uh.edu 2010-11-29 12:25:22 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Bug 652403 depends on bug 652400, which changed state.
Bug 652400 Summary: Review Request: rubygem-boxgrinder-build - Creates appliances for various virtual environments https://bugzilla.redhat.com/show_bug.cgi?id=652400
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED Status|MODIFIED |ON_QA Resolution| |ERRATA Status|ON_QA |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-12-09 07:18:49 EST --- rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-boxgrinder-build-rpm-based-o...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2010-12-09 07:19:26 EST --- rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-boxgrinder-build-rpm-based-o...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2010-12-09 16:59:30 EST --- rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-boxgrinder-build-rpm-based-os-plugin'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-boxgrinder-build-rpm-based-o...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution| |NEXTRELEASE Last Closed| |2010-12-10 13:20:00
--- Comment #15 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-12-10 13:20:00 EST --- Closing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2010-12-17 15:26:20 EST --- rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |rubygem-boxgrinder-build-rp | |m-based-os-plugin-0.0.8-3.f | |c14 Resolution|NEXTRELEASE |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
--- Comment #17 from Fedora Update System updates@fedoraproject.org 2010-12-17 15:31:28 EST --- rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|rubygem-boxgrinder-build-rp |rubygem-boxgrinder-build-rp |m-based-os-plugin-0.0.8-3.f |m-based-os-plugin-0.0.8-3.f |c14 |c13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
Marek Goldmann mgoldman@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #18 from Marek Goldmann mgoldman@redhat.com 2011-01-25 03:04:19 EST --- Package Change Request ====================== Package Name: rubygem-boxgrinder-build-rpm-based-os-plugin New Branches: el5 el6 Owners: goldmann
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652403
--- Comment #19 from Jason Tibbitts tibbs@math.uh.edu 2011-01-25 09:08:35 EST --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org