https://bugzilla.redhat.com/show_bug.cgi?id=1031527
Bug ID: 1031527 Summary: Review Request: datefudge - fakes the system date/time Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: nmavrogi@redhat.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://people.redhat.com/nmavrogi/fedora/datefudge.spec SRPM URL: http://people.redhat.com/nmavrogi/fedora/datefudge-1.18-1.fc20.src.rpm
Description: This program (and preload library) fakes the system date so that programs think the wall clock is ... different. The faking is not complete; time-stamp on files are not affected in any way. This package is useful if you want to test the date handling of your programs without changing the system clock. This is particularly useful when checking the handling of programs of certificate expiration/activation etc.
Fedora Account System Username: nmav
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |cickumqt@gmail.com Assignee|nobody@fedoraproject.org |cickumqt@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
--- Comment #1 from Christopher Meng cickumqt@gmail.com --- First, do you want to support EL5?
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
--- Comment #2 from Nikos Mavrogiannopoulos nmavrogi@redhat.com --- Hello, I really don't know. Is there a reason for not supporting it?
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
--- Comment #3 from Christopher Meng cickumqt@gmail.com --- (In reply to Nikos Mavrogiannopoulos from comment #2)
Hello, I really don't know. Is there a reason for not supporting it?
I don't know, but if you don't want to support EL5, you need to remove some lines as modern RPM doesn't need these lines.
I don't know which os you are using, but I don't think we need to care about EL5.(Just my opinion)
Waiting for your final answer.
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
--- Comment #4 from Nikos Mavrogiannopoulos nmavrogi@redhat.com --- I have no particular reason to support EL5, so indeed I should drop anything unneeded.
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
--- Comment #5 from Christopher Meng cickumqt@gmail.com --- Ok.
So:
1. Remove these:
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
rm -rf %{buildroot} in %install
Whole %clean
%defattr(-,root,root,-)
2. URL better use PTS page:
http://packages.qa.debian.org/d/datefudge.html
3. Source0 better use CDN:
http://cdn.debian.net/debian/pool/main/d/datefudge/datefudge_1.18.tar.gz
with macro replaced, too.
4. I checked your patch.
INSTALL_PROGRAM := "install" should also be patched to
INSTALL_PROGRAM := "install -p"
5. $(CFLAGS) should be inserted with %{optflags}:
http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
You can define cflags like make CFLAGS="%{optflags}"
And $(LDFLAGS) also should be defined with %{__global_ldflags}
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
--- Comment #6 from Nikos Mavrogiannopoulos nmavrogi@redhat.com --- Thanks. It's now updated based on your comments. I've uploaded a -2 version.
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
--- Comment #7 from Christopher Meng cickumqt@gmail.com --- Please paste the new URL.
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
--- Comment #8 from Nikos Mavrogiannopoulos nmavrogi@redhat.com --- (In reply to Christopher Meng from comment #7)
Please paste the new URL.
Spec URL: http://people.redhat.com/nmavrogi/fedora/datefudge.spec SRPM URL: http://people.redhat.com/nmavrogi/fedora/datefudge-1.18-2.fc20.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #9 from Christopher Meng cickumqt@gmail.com --- datefudge.i686: E: incorrect-fsf-address /usr/share/doc/datefudge/COPYING
Please notify upstream about this.
-------------
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
Nikos Mavrogiannopoulos nmavrogi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #10 from Nikos Mavrogiannopoulos nmavrogi@redhat.com --- New Package SCM Request ======================= Package Name: datefudge Short Description: fakes the system date/time Owners: nmav Branches: f19 f20
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
--- Comment #11 from Nikos Mavrogiannopoulos nmavrogi@redhat.com --- (In reply to Christopher Meng from comment #9)
datefudge.i686: E: incorrect-fsf-address /usr/share/doc/datefudge/COPYING
Please notify upstream about this.
PACKAGE APPROVED.
Notified, thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
--- Comment #12 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
Nikos Mavrogiannopoulos nmavrogi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2013-11-19 08:30:52
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |MODIFIED Resolution|NEXTRELEASE |--- Keywords| |Reopened
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- datefudge-1.18-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/datefudge-1.18-2.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- datefudge-1.18-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/datefudge-1.18-2.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- datefudge-1.18-2.fc20 has been pushed to the Fedora 20 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |datefudge-1.18-2.fc19 Resolution|--- |ERRATA Last Closed|2013-11-19 08:30:52 |2013-12-01 04:31:17
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- datefudge-1.18-2.fc19 has been pushed to the Fedora 19 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1031527
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|datefudge-1.18-2.fc19 |datefudge-1.18-2.fc20
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- datefudge-1.18-2.fc20 has been pushed to the Fedora 20 stable repository.
package-review@lists.fedoraproject.org