https://bugzilla.redhat.com/show_bug.cgi?id=2079251
--- Comment #3 from Ondřej Sloup <osloup(a)redhat.com> ---
Could you please add a comment describing why you need the libpq.sgml
file?
`libpq.sgml is needed as part of the documentation. If not present,
documentation build will try to download and fail ` comment added.
I see that you are building manual pages but the result is not
installed to the correct location and therefore it's not available for the man
command.
I added configuration for the man pages and it is now available with man
command.
Also, one big issue is that there is no definition of python3-
subpackage. The name of the component and the specfile should be python-psycopg3, but it
should produce python3-psycopg3.
I created a package as requested.
Also, the version in the changelog should contain the release number.
Added `-1` to the version.
The documentation should be built in %build, not in %check.
Moved to %build and %install. I separated the process to make it clearer.
It'd be better to exclude specific tests instead of removing the
whole files but it depends on how many tests are failing there and why.
The tests in
the directory are testing the `psycopg_pool` object, which is not
available. Once this package is released, it will be added as a dependency for
those tests, and then they can be run.
That is why I remove all the tests until the `psycopg_pool` object is added to
Fedora to prevent breaking changes by adding more tests in that directory.
Also, why it's necessary to remove the import of the main package
from the configuration of the documentation?
The `psycopg` package is not available
during the build, and therefore it
cannot be imported when building the documentation. I removed it so the
documentation can be created.
The build of the documentation does not require gcc, it only requires
make.
I changed `gcc` to `make`.
The tests are mostly skipped: 239 passed, 3023 skipped not sure there
is something we can do about it.
without lines 112 - 114:
=========== 92 failed, 239 passed, 3143 skipped in 267.25s (0:04:27)
===========
without lines 112 - 114 and with DNS package installed:
===== 92 failed, 239 passed, 3104 skipped, 39 errors in 273.38s (0:04:33)
======
with pytest-cov:
====================== 239 passed, 3023 skipped in 3.29s
=======================
Current solution:
====================== 239 passed, 3023 skipped in 3.15s ======================
Since the only other thing I'm excluding is pproxy, I think that most of the
tests use this package, and those tests are not run by skipping it.
However, as pproxy is not in Fedora, I don't think a better solution is
available.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2079251