https://bugzilla.redhat.com/show_bug.cgi?id=983843
Bug ID: 983843 Summary: Review Request: python-flask-bootstrap - Twitter's Bootstrap in your project, without any boilerplate code Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Assignee: nobody@fedoraproject.org Reporter: yohangraterol92@gmail.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
SPEC URL: http://yograterol.fedorapeople.org/python-flask-bootstrap.spec SRPM URL: http://yograterol.fedorapeople.org/python-flask-bootstrap-2.3.2.1-1.fc19.src...
python-flask-bootstrap
An extension that includes Twitter's Bootstrap in your project, without any boilerplate code.
Flask-Bootstrap packages Twitter's Bootstrap into an extension that mostly consists of a blueprint named 'bootstrap'. It can also create links to serve Bootstrap from a CDN.
FAS User: yograterol
https://bugzilla.redhat.com/show_bug.cgi?id=983843
Eduardo Echeverria echevemaster@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |echevemaster@gmail.com Assignee|nobody@fedoraproject.org |echevemaster@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=983843
--- Comment #1 from Eduardo Echeverria echevemaster@gmail.com --- Hi Yohan, some commentaries:
/usr/lib/python2.7/site-packages/flask_bootstrap/__init__.py have permissions of 0644, the file contains shebang, please add executable bit, also the package doesn't contains a valid license file, query in upstream for adding to it (according to pipy's site, the license is BSD)-
also the package bundle a boostrap copy, in this moment Fedora doesn't require client-side JavaScript to be unbundled: see https://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system_li..., hence no problem here, but boostrap is licensed under ASL2.0 and Glyphicons Free licensed under CC BY 3.0. http://creativecommons.org/licenses/by/3.0/, please query in upstream the licenses and add in %prep section and in the license field, please see https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licens..., also the awesome font is licensed under OFL http://scripts.sil.org/cms/scripts/page.php?site_id=nrsi&id=OFL_web, and awesome css is licensed under MIT
Cheers
https://bugzilla.redhat.com/show_bug.cgi?id=983843
--- Comment #2 from Yohan Graterol yohangraterol92@gmail.com --- Hi echevemaster,
Thank u for your review, here is new spec.
SPEC: http://yograterol.fedorapeople.org/python-flask-bootstrap.spec SPRM: http://yograterol.fedorapeople.org/python-flask-bootstrap-2.3.2.2-1.fc19.src...
Regards!
https://bugzilla.redhat.com/show_bug.cgi?id=983843
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@gmail.com, | |yohangraterol92@gmail.com Flags| |needinfo?(yohangraterol92@g | |mail.com)
--- Comment #3 from Christopher Meng cickumqt@gmail.com --- When you are free, please review.
Cheers.
https://bugzilla.redhat.com/show_bug.cgi?id=983843
Yohan Graterol yohangraterol92@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(yohangraterol92@g | |mail.com) |
--- Comment #4 from Yohan Graterol yohangraterol92@gmail.com --- I'm waiting the next version of that library.
https://bugzilla.redhat.com/show_bug.cgi?id=983843
--- Comment #5 from Eduardo Echeverria echevemaster@gmail.com --- flask-bootstrap 3.0.0.1 it has released, please build the newest version for continue the review https://pypi.python.org/pypi/Flask-Bootstrap
https://bugzilla.redhat.com/show_bug.cgi?id=983843
--- Comment #6 from Yohan Graterol yohangraterol92@gmail.com --- New Version
SPEC: http://yograterol.fedorapeople.org/python-flask-bootstrap.spec SPRM: http://yograterol.fedorapeople.org/python-flask-bootstrap-3.0.3.1-1.fc19.src...
https://bugzilla.redhat.com/show_bug.cgi?id=983843
Pete Travis me@petetravis.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |me@petetravis.com
--- Comment #7 from Pete Travis me@petetravis.com --- The fonts from bootstrap (and flask-bootstrap) are glyphicons-halflings-regular, not glyphicons-free. I have a review going for glyphicons-halflings-regular[1] as a font-only package. Bootstrap Once it is complete, you can symlink to %{_datadir}/fonts/glyphicons-halflings and avoid bundling the font.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1050805
https://bugzilla.redhat.com/show_bug.cgi?id=983843
Charalampos Stratakis cstratak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cstratak@redhat.com Flags| |needinfo?(yohangraterol92@g | |mail.com)
--- Comment #8 from Charalampos Stratakis cstratak@redhat.com --- Flask-Bootstrap is still active upstream.
Is there still an interest on adding this package to Fedora?
https://bugzilla.redhat.com/show_bug.cgi?id=983843
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED CC| |zbyszek@in.waw.pl Resolution|--- |DUPLICATE Flags|needinfo?(yohangraterol92@g | |mail.com) | Last Closed| |2016-11-13 11:48:09
--- Comment #9 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Six weeks without reply. There's a duplicate review that is more alive.
*** This bug has been marked as a duplicate of bug 1388908 ***
package-review@lists.fedoraproject.org