Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=520561
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com> 2009-09-02 02:38:55 EDT
---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1647297
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
9a2f8d71777f06b846da61988398d75153846bbd Moose-Autobox-0.09.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=9, Tests=156, 5 wallclock secs ( 0.10 usr 0.02 sys + 4.68 cusr 0.18
csys = 4.98 CPU)
+ Package perl-Moose-Autobox-0.09-1.fc12.noarch =>
Provides: perl(Moose::Autobox) = 0.09 perl(Moose::Autobox::ARRAY)
perl(Moose::Autobox::Array) = 0.09 perl(Moose::Autobox::CODE)
perl(Moose::Autobox::Code) = 0.09 perl(Moose::Autobox::Defined) = 0.09
perl(Moose::Autobox::HASH) perl(Moose::Autobox::Hash) = 0.09
perl(Moose::Autobox::Indexed) = 0.09 perl(Moose::Autobox::Item) = 0.09
perl(Moose::Autobox::List) = 0.09 perl(Moose::Autobox::Number) = 0.09
perl(Moose::Autobox::Ref) = 0.09 perl(Moose::Autobox::SCALAR)
perl(Moose::Autobox::Scalar) = 0.09 perl(Moose::Autobox::String) = 0.09
perl(Moose::Autobox::Undef) = 0.09 perl(Moose::Autobox::Value) = 0.09
Requires: perl >= 0:5.006 perl(base) perl(Carp) perl(metaclass)
perl(Moose::Autobox) perl(Moose::Autobox::Array) perl(Moose::Autobox::Code)
perl(Moose::Autobox::Hash) perl(Moose::Autobox::Scalar)
perl(Moose::Autobox::Undef) perl(Moose::Role) perl(Moose::Util)
perl(Perl6::Junction) perl(Scalar::Util) perl(strict) perl(warnings)
rpmlib(VersionedDependencies) <= 3.0.3-1
+ Not a GUI application
APPROVED.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.