https://bugzilla.redhat.com/show_bug.cgi?id=1530431
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |zebob.m(a)gmail.com
Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com
Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
- You need systemd requires too, add:
%{?systemd_requires}
BuildRequires: systemd
See
https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd
- The license file mist be installed with the %license macro, not %doc:
%files
%license LICENSE
- Some dirs are not owned:
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python3.6/site-
packages/nodepool/driver, /usr/lib/python3.6
/site-packages/nodepool, /etc/nodepool
- gitdate should not be separated by dots:
%global gitdate 20171214
- The Release field should mention the type of VCS:
Release: 1.%{gitdate}git%{shortcommit}%{?dist}
- The %changelog release info are not identical to the header ones:
* Wed Jan 3 2018 Tristan Cacqueray <tdecacqu(a)redhat.com> -
0.4.0-1.20171214gita20d81c
- Fix the line encodings for the LICENSE file:
nodepool-launcher.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/nodepool-launcher/LICENSE
- You must ship a logrotate config file for your log. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Logrotate_config_file
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file LICENSE is not marked as %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "*No copyright* Apache", "Unknown
or
generated", "*No copyright* Apache (v2.0)". 33 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/nodepool/review-nodepool/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /etc/nodepool
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python3.6/site-
packages/nodepool/driver, /usr/lib/systemd/system, /usr/lib/python3.6
/site-packages/nodepool, /etc/nodepool, /usr/lib/systemd
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
→ Missing sytemd requires
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 81920 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[ ]: Python eggs must not download any dependencies during the build
process.
[ ]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
nodepool-launcher , nodepool-driver-openstack , nodepool-builder
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: nodepool-0.4.0-1.2017.12.14.a20d81c.fc28.noarch.rpm
nodepool-launcher-0.4.0-1.2017.12.14.a20d81c.fc28.noarch.rpm
nodepool-driver-openstack-0.4.0-1.2017.12.14.a20d81c.fc28.noarch.rpm
nodepool-builder-0.4.0-1.2017.12.14.a20d81c.fc28.noarch.rpm
nodepool-doc-0.4.0-1.2017.12.14.a20d81c.fc28.noarch.rpm
nodepool-0.4.0-1.2017.12.14.a20d81c.fc28.src.rpm
nodepool.noarch: W: spelling-error %description -l en_US devstack -> devastate
nodepool.noarch: W: incoherent-version-in-changelog 0.4.0-1
['0.4.0-1.2017.12.14.a20d81c.fc28', '0.4.0-1.2017.12.14.a20d81c']
nodepool.noarch: W: non-standard-gid /etc/nodepool/secure.conf nodepool
nodepool.noarch: E: non-readable /etc/nodepool/secure.conf 640
nodepool.noarch: E: zero-length /etc/nodepool/secure.conf
nodepool.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/nodepool/LICENSE
nodepool.noarch: W: non-standard-uid /var/lib/nodepool nodepool
nodepool.noarch: W: non-standard-gid /var/lib/nodepool nodepool
nodepool.noarch: E: non-standard-dir-perm /var/lib/nodepool 750
nodepool.noarch: W: non-standard-uid /var/lib/nodepool/.config nodepool
nodepool.noarch: W: non-standard-gid /var/lib/nodepool/.config nodepool
nodepool.noarch: W: hidden-file-or-dir /var/lib/nodepool/.config
nodepool.noarch: E: non-standard-dir-perm /var/lib/nodepool/.config 750
nodepool.noarch: W: hidden-file-or-dir /var/lib/nodepool/.config
nodepool.noarch: W: non-standard-uid /var/lib/nodepool/.config/openstack
nodepool
nodepool.noarch: W: non-standard-gid /var/lib/nodepool/.config/openstack
nodepool
nodepool.noarch: E: non-standard-dir-perm /var/lib/nodepool/.config/openstack
750
nodepool.noarch: W: non-standard-uid /var/lib/nodepool/dib nodepool
nodepool.noarch: W: non-standard-gid /var/lib/nodepool/dib nodepool
nodepool.noarch: E: non-standard-dir-perm /var/lib/nodepool/dib 750
nodepool.noarch: W: non-standard-uid /var/log/nodepool nodepool
nodepool.noarch: W: non-standard-gid /var/log/nodepool nodepool
nodepool.noarch: E: non-standard-dir-perm /var/log/nodepool 750
nodepool.noarch: W: log-files-without-logrotate ['/var/log/nodepool']
nodepool.noarch: W: no-manual-page-for-binary nodepool
nodepool-launcher.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/nodepool-launcher/LICENSE
nodepool-launcher.noarch: W: no-manual-page-for-binary nodepool-launcher
nodepool-launcher.noarch: W: empty-%postun
nodepool-driver-openstack.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/nodepool-driver-openstack/LICENSE
nodepool-builder.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/nodepool-builder/LICENSE
nodepool-builder.noarch: W: non-standard-uid /var/cache/nodepool nodepool
nodepool-builder.noarch: W: non-standard-gid /var/cache/nodepool nodepool
nodepool-builder.noarch: W: non-standard-uid /var/cache/nodepool/dib_cache
nodepool
nodepool-builder.noarch: W: non-standard-gid /var/cache/nodepool/dib_cache
nodepool
nodepool-builder.noarch: W: non-standard-uid /var/cache/nodepool/dib_tmp
nodepool
nodepool-builder.noarch: W: non-standard-gid /var/cache/nodepool/dib_tmp
nodepool
nodepool-builder.noarch: W: no-manual-page-for-binary nodepool-builder
nodepool-builder.noarch: W: empty-%postun
nodepool-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/nodepool-doc/LICENSE
nodepool-doc.noarch: W: hidden-file-or-dir
/usr/share/doc/nodepool-doc/html/.buildinfo
nodepool-doc.noarch: W: hidden-file-or-dir
/usr/share/doc/nodepool-doc/html/.doctrees
nodepool-doc.noarch: W: hidden-file-or-dir
/usr/share/doc/nodepool-doc/html/.doctrees
nodepool.src: W: spelling-error %description -l en_US devstack -> devastate
6 packages and 0 specfiles checked; 7 errors, 36 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component