Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: nvclock - Utility that allows users to overclock NVIDIA based
video cards
https://bugzilla.redhat.com/show_bug.cgi?id=427618
------- Additional Comments From adel.gadllah(a)gmail.com 2008-01-05 13:38 EST -------
(In reply to comment #2)
Problems:
1. License field says GPLv2+, but
src/libc_wrapper.c has MIT license (GPLv2+ compatible)
so should I add GPLv2+ and
MIT ?
src/backend/i2c.c and nv40.c have some additional (apart from the
GPL) clauses -
can you verify that they don't impose any restrictions over GPL terms?
I asked upstream and got this response
"it are just some pieces from xfree86, the same stuff that is now in the xorg nv
driver"
2. This part could use a little more spacing for legibility:
[...]
%package gtk
Summary: Nvclock gtk frontend
Group: Applications/System
%description gtk
This package contains the nvclock gui.
[...]
ok
3. make is called without %{?_smp_mflag} and no comment is present
explaining why.
because the build fails; have not yet investigated why .. will add a comment.
4. Since the icon you add is 48x48, why not put it in
%{_datadir}/icons/hicolor/48x48/apps/
?
Of course, then you need to add
%post gtk
touch --no-create %{_datadir}/icons/hicolor
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi
%postun gtk
touch --no-create %{_datadir}/icons/hicolor
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi
OK, will do.
5. Why aren't you building the QT interface? AFAICT it builds and
works just as
well as the GTK interface.
Because its unmaintained and upstream is planning to drop it completly.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.