Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: ruby-spqr - easy QMF agent framework for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=711229
Summary: Review Request: ruby-spqr - easy QMF agent framework for Ruby Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: willb@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://packages.getwallaby.com/ruby-spqr.spec SRPM URL: http://packages.getwallaby.com/ruby-spqr-0.3.3-2.fc14.src.rpm Description: SPQR makes it very simple to expose methods on Ruby objects over the Qpid Management Framework.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711229
Will Benton willb@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711229
--- Comment #1 from Will Benton willb@redhat.com 2011-09-21 22:37:17 EDT --- A new SRPM is available at http://packages.getwallaby.com/ruby-spqr-0.3.3-4.fc14.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711229
--- Comment #2 from Will Benton willb@redhat.com 2011-10-31 15:45:05 EDT --- The most recent SRPM is available from packages.getwallaby.com.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711229
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tcallawa@redhat.com Blocks|177841(FE-NEEDSPONSOR) | AssignedTo|nobody@fedoraproject.org |tcallawa@redhat.com Flag| |fedora-review+
--- Comment #3 from Tom "spot" Callaway tcallawa@redhat.com 2011-11-04 14:13:12 EDT --- == Review == Good:
- rpmlint checks return: ruby-spqr.noarch: W: spurious-executable-perm /usr/share/doc/ruby-spqr-0.3.4/examples/hello.rb ruby-spqr.noarch: W: doc-file-dependency /usr/share/doc/ruby-spqr-0.3.4/examples/logservice.rb /usr/bin/env spqr-gen.noarch: W: spelling-error Summary(en_US) xml -> XML, ml, x ml spqr-gen.noarch: W: no-manual-page-for-binary spqr-gen.rb
All safe to ignore.
- package meets naming guidelines - package meets packaging guidelines - license (ASL 2.0) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (d3ef30d1000f1f00187cc1a6d59d8713e37701b21d4ff4c90368f55a33ad6e5a) - package compiles on f16 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file
It all looks good, so I'm marking this as APPROVED.
One minor item: I don't think there is a need for Requires: ruby, since you have Requires: ruby(abi) = 1.8, but this should be safe to remove before committing to Fedora git.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711229
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #4 from Vít Ondruch vondruch@redhat.com 2011-11-08 12:59:59 EST --- Hi, could you please enlighten me why did you packaged the library as Ruby library instead of RubyGem?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711229
Will Benton willb@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Will Benton willb@redhat.com 2011-12-22 11:24:16 EST --- New Package SCM Request ======================= Package Name: ruby-spqr Short Description: easy QMF agent framework for Ruby Owners: willb Branches: f15 f16 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711229
--- Comment #6 from Jon Ciesla limburgher@gmail.com 2011-12-22 11:39:03 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711229
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711229
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2012-01-04 17:24:32 EST --- ruby-spqr-0.3.5-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ruby-spqr-0.3.5-1.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711229
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2012-01-04 17:25:14 EST --- ruby-spqr-0.3.5-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ruby-spqr-0.3.5-1.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711229
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2012-01-05 16:00:12 EST --- ruby-spqr-0.3.5-1.fc15 has been pushed to the Fedora 15 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711229
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |ruby-spqr-0.3.5-1.fc15 Resolution| |ERRATA Last Closed| |2012-01-13 22:57:24
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2012-01-13 22:57:24 EST --- ruby-spqr-0.3.5-1.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711229
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2012-01-15 14:57:44 EST --- ruby-spqr-0.3.5-1.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=711229
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|ruby-spqr-0.3.5-1.fc15 |ruby-spqr-0.3.5-1.fc16
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2012-01-15 14:59:39 EST --- ruby-spqr-0.3.5-1.fc16 has been pushed to the Fedora 16 stable repository.
package-review@lists.fedoraproject.org