https://bugzilla.redhat.com/show_bug.cgi?id=851641
--- Comment #4 from Sebastian Dyroff <bugs(a)dyroff.org> ---
(In reply to comment #3)
First of all thanks for the feedback.
Drop the Requires line. rpmbuild is able to figure that out.
qt3-devel would
have been wrong anyway.
If I drop that line, I will get a runtime error complaining about the missing
assistant executable(qt-assistant). Yum provides lists qt3-devel as providing
package for this file. But there should be a comment in the spec-file.
As far as I can see, this package bundles code from at least Argyll
and
wxwidgets which is not allowed. Some snapshot of SCons is included as well.
What is a common way to fix this? Best fix would be if upstream could clean the
release directory. Is it also a valid fix to remove the components and create a
new release archive? Removing the SCons part is trivial, it is not used anyway.
Removing wxwidgets and Argyll might be harder.
What is Patch0 good for? Please put a comment in the spec file and
refer to
an upstream ticket, if possible.
I will file a bug upstream for that. The Patch0 is also included in the Debian
package. Without this patch it won't compile, with the error: 'BOOL' does not
name a type.
"""
%{_datadir}/%{name}/data/pics/*
%{_datadir}/%{name}/data/profiles/*
%{_datadir}/%{name}/data/template/*
"""
Using this syntax, you don't own {_datadir}/%{name}. I'd just replace those
three lines with:
{_datadir}/%{name}
I did this in the first version, the problem is that
%{_datadir}/%{name}/data/translations/ must be excluded because %find_lang
takes care of these files. Is it OK to change the line %files -f %{name}.lang
to just %files?
Please use the name macro for the patch names. I also suggest to use
it for
the icon and desktop file.
I personally consider "open source" not worth mentioning and only bloating
description and summary, because everything in Fedora is Free Software.
That idea came to me too, after filing this bug. It is the project description
on sourceforge :-).
--
You are receiving this mail because:
You are on the CC list for the bug.