Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947
Summary: Review Request: gwenhywfar - utility library Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: notting@redhat.com QAContact: fedora-package-review@redhat.com
Spec URL: http://people.redhat.com/notting/review/gwenhywfar.spec SRPM URL: http://people.redhat.com/notting/review/gwenhywfar-2.3.0-5.src.rpm Description: gwenhywfar utility library
gwenhywfar is a utility library used by aqbanking. This is part of reviewing the gnucash stack.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gwenhywfar - utility library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |panemade@gmail.com OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gwenhywfar - utility library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947
------- Additional Comments From panemade@gmail.com 2007-01-10 02:47 EST ------- rpmlint is not silent rpmlint on main RPM reported W: gwenhywfar non-conffile-in-etc /etc/gwen-public-ca.crt A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file.
rpmlint on -devel rpm reported I: gwenhywfar-devel checking E: gwenhywfar-devel only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share.
Otherwise mock build is fine.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gwenhywfar - utility library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947
------- Additional Comments From notting@redhat.com 2007-01-10 09:35 EST ------- (In reply to comment #1)
W: gwenhywfar non-conffile-in-etc /etc/gwen-public-ca.crt
It's not really a configuration file, it's a data file. It's a CA certificate bundle, much like /etc/pki/tls/certs/ca-bundle.crt. However, that is also marked %config, so I'll change this.
(Ideally it just uses the openssl CA bundle.)
E: gwenhywfar-devel only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share.
This is a mis-error from rpmlint. It's a architecture-specific include, so it can't be in /usr/include, and needs to be in an architecture specific directory. See glib2, dbus, gcc, qt for other examples of this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gwenhywfar - utility library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947
------- Additional Comments From paul@city-fan.org 2007-01-10 10:28 EST ------- (In reply to comment #2)
(In reply to comment #1)
W: gwenhywfar non-conffile-in-etc /etc/gwen-public-ca.crt
It's not really a configuration file, it's a data file. It's a CA certificate bundle, much like /etc/pki/tls/certs/ca-bundle.crt. However, that is also marked %config, so I'll change this.
Perhaps it should live in /etc/pki/tls/certs too?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gwenhywfar - utility library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947
------- Additional Comments From notting@redhat.com 2007-01-10 12:03 EST ------- It's not easily modifiable without patching, and if I'm going to do that, I'd rather just patch it to *use* the openssl one. Currently discussing that w/upstream.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gwenhywfar - utility library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947
------- Additional Comments From paul@city-fan.org 2007-01-10 12:12 EST ------- FWIW, curl uses the openssl one rather than the one shipped in the curl tarball...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gwenhywfar - utility library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947
------- Additional Comments From notting@redhat.com 2007-01-11 17:54 EST ------- 2.3.0-6 uploaded; cert bundle marked as config, rpaths fixed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gwenhywfar - utility library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From panemade@gmail.com 2007-01-12 01:52 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM. - rpmlint is NOT silent for RPMS. E: gwenhywfar-devel only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. But its ok as it looks mis-error by rpmlint.
+ source files match upstream. 0f7cf7d0efa6719f85c00d6d8ccec2b3 gwenhywfar-2.3.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code Not contents. + no static libraries present. + no gwenhywfar.pc files present. + -devel subpackage exists + included %post -p /sbin/ldconfig %postun -p /sbin/ldconfig + no .la files. + translations are available + Dose owns the directories it creates. + no duplicates in %files. + no scriptlets used. + file permissions are appropriate. APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gwenhywfar - utility library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947
------- Additional Comments From notting@redhat.com 2007-01-12 10:04 EST ------- Just looking over:
(In reply to comment #7)
- no gwenhywfar.pc files present.
It certainly has them in my builds...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gwenhywfar - utility library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947
------- Additional Comments From panemade@gmail.com 2007-01-12 10:22 EST ------- (In reply to comment #8)
Just looking over:
(In reply to comment #7)
- no gwenhywfar.pc files present.
It certainly has them in my builds...
oops Sorry. I actually used to copy my Review Template and modify them according to package. I forgot to remove no word.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gwenhywfar - utility library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947
------- Additional Comments From panemade@gmail.com 2007-02-22 00:09 EST ------- Ping any problem for importing this package to CVS?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gwenhywfar - utility library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947
------- Additional Comments From notting@redhat.com 2007-02-22 11:16 EST ------- Just waiting for the round tuits. Will get to it this week-ish.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gwenhywfar - utility library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947
notting@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
------- Additional Comments From notting@redhat.com 2007-03-19 15:32 EST ------- This is built now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gwenhywfar - utility library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium
notting@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Keywords| |Reopened Resolution|RAWHIDE | Flag| |fedora-cvs?
------- Additional Comments From notting@redhat.com 2007-06-08 21:17 EST ------- Package Change Request ====================== Package Name: gwenhywfar New Branches: EL-4 EL-5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gwenhywfar - utility library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gwenhywfar - utility library
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From tibbs@math.uh.edu 2007-06-08 23:59 EST ------- CVS done.
package-review@lists.fedoraproject.org