https://bugzilla.redhat.com/show_bug.cgi?id=1135470
Bug ID: 1135470 Summary: Review Request: kf5-kscreen - A Tier 3 KDE Frameworks 5 Library with API to control screen settings Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: dvratil@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Blocks: 1135103 (plasma5)
Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kf5-kscreen.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kf5-kscreen-5.0.92-1.fc20.sr... Description: A Tier 3 KDE Frameworks 5 Library with API to control screen settings. Fedora Account System Username: dvratil
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1135103 [Bug 1135103] Plasma 5 Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
Jan Grulich jgrulich@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jgrulich@redhat.com Docs Contact| |jgrulich@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
Jan Grulich jgrulich@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Jan Grulich jgrulich@redhat.com --- In Description macro %{Summary} will be unexpanded so use %{summary} instead. You are also missing to install license file. The rest looks good and both mentioned issues could be done during import.
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@math.unl.edu
--- Comment #2 from Rex Dieter rdieter@math.unl.edu --- Similar to my comments in the kf5-libmm-qt review, I think we could consider recycling the existing fedora pkg/module libkscreen , the only items that currently depend on it are kscreen (should have plasma5 version soonish, right?) okular (optional feature)
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
--- Comment #3 from Rex Dieter rdieter@math.unl.edu --- If not, I'd prefer this be called kf5-libkscreen (to match the tarball)
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
Daniel Vrátil dvratil@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |WONTFIX Last Closed| |2014-12-19 11:21:06
--- Comment #4 from Daniel Vrátil dvratil@redhat.com --- Unlike libmm-qt/libnm-qt, libkscreen is not going to become a KDE Framework, instead will remain as a support library for Plasma 5, so I agree that we can just reuse the existing libkscreen package. Closing this request.
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
Daniel Vrátil dvratil@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |NEW Resolution|WONTFIX |--- Keywords| |Reopened
--- Comment #5 from Daniel Vrátil dvratil@redhat.com --- Reopening: libkscreen is required by okular-libs. Unless we make sure we have KF5-based Okular in rawhide (I don't know what the porting plans of Okular are), we might need to go for libkscreen-qt5 or something like that. Opinions?
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
--- Comment #6 from Rex Dieter rdieter@math.unl.edu --- -qt5 is fine with me if you don't want to use kf5- prefix for reasons(tm).
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
Daniel Vrátil dvratil@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: kf5-kscreen |Review Request: |- A Tier 3 KDE Frameworks 5 |libkscreen-qt5 - KDE |Library with API to control |display configuration |screen settings |library Alias| |libkscreen-qt5
--- Comment #7 from Daniel Vrátil dvratil@redhat.com --- Spec URL: https://dvratil.fedorapeople.org/plasma5/review/libkscreen-qt5.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/libkscreen-qt5-5.1.95-1.beta...
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
--- Comment #8 from Jan Grulich jgrulich@redhat.com --- Output from rpmlint: libkscreen-qt5.src: W: invalid-url URL: https://projects.kde.org/projects/extragear/libs/libkscreen HTTP Error 404: Not Found libkscreen-qt5.src:1: W: macro-in-comment %global libkscreen-qt5.src:2: W: macro-in-comment %global libkscreen-qt5.src:17: W: macro-in-comment %{git_version} 1 packages and 0 specfiles checked; 0 errors, 4 warnings.
No blocking issue spotted, just fix the url during import.
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
Daniel Vrátil dvratil@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #9 from Daniel Vrátil dvratil@redhat.com --- New Package SCM Request ======================= Package Name: libkscreen-qt5 Short Description: KDE display configuration library Upstream URL: https://projects.kde.org/projects/kde/workspace/libkscreen Owners: group::kde-sig Branches: InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
--- Comment #10 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
Daniel Vrátil dvratil@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |CURRENTRELEASE Last Closed|2014-12-19 11:21:06 |2015-01-29 09:58:40
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
Daniel Vrátil dvratil@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|CURRENTRELEASE |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
Ngo Than than@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED CC| |than@redhat.com Resolution|RAWHIDE |--- Flags|fedora-cvs+ |
--- Comment #11 from Ngo Than than@redhat.com --- New Package SCM Request ======================= Package Name: libkscreen-qt5 Short Description: KDE display configuration library Upstream URL: https://projects.kde.org/projects/kde/workspace/libkscreen Owners: group::kde-sig Branches: epel7
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
Ngo Than than@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |limburgher@gmail.com Flags| |needinfo?(limburgher@gmail. | |com)
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(limburgher@gmail. | |com) |
https://bugzilla.redhat.com/show_bug.cgi?id=1135470
Ngo Than than@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE Last Closed|2015-01-29 09:58:40 |2016-05-25 04:26:05
--- Comment #13 from Ngo Than than@redhat.com --- thanks
package-review@lists.fedoraproject.org