https://bugzilla.redhat.com/show_bug.cgi?id=1519834
--- Comment #5 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
There are new macros you should use:
https://src.fedoraproject.org/rpms/mpich/blob/master/f/mpich.macros
https://src.fedoraproject.org/rpms/openmpi/blob/master/f/macros.openmpi
- Use %_mpich_load / %_mpich_unload / %_openmpi_load / %_openmpi_load
- Use %bcond_with / %bcond_without for all the conditional
- This is not really elegant, anyhow remove the shebangs alltogether, in %prep
if possible
# Fix python interpreter for libraries
for f in $(find -L ${RPM_BUILD_ROOT}/%{python3_sitelib} -executable -type f)
do
sed -i 's|#!/usr/bin/env python|#!/usr/bin/python3|' $f
sed -i 's|#!/usr/bin/env python3|#!/usr/bin/python3|' $f
sed -i 's|#!/usr/bin/python|#!/usr/bin/python3|' $f
# remove introduced but excessive 3's
sed -i 's|#!/usr/bin/python333|#!/usr/bin/python3|' $f
sed -i 's|#!/usr/bin/python33|#!/usr/bin/python3|' $f
done
- Take into account RHEL8/EPEL8 for your conditions, as in if epel and epel <
8
- Also but more linebreaks between sections, the SPEC is difficult to read
- I'm not sure what you're trying to do here, but that's not how to include
a
Patch:
echo "diff -Naur a/make.config b/make.config
--- a/make.config 2017-05-02 23:03:57.298625399 +0100
+++ b/make.config 2017-05-02 23:04:26.460489477 +0100
@@ -23,6 +23,7 @@
SLEPC_DIR ?=
SLEPC_ARCH ?=
+RELEASED = %{version}-%{release}
# These lines can be replaced in \"make install\" to point to install
directories
# They are used in the CXXFLAGS variable below rather than hard-coding the
directories
" | patch --no-backup-if-mismatch -p1 --fuzz=0
${RPM_BUILD_ROOT}/%{_includedir}/${mpi}-%{_arch}/bout++/make.config
Use sed in %prep on make.config.in to add your line
- Why is this in check:
for f in $(find -L ${RPM_BUILD_ROOT}/%{python3_sitelib}/ -type f|grep
'\.pyc\$|\.pyo\$')
do
echo cleaning $f
rm $f
done
- Don't be so specific in %files:
%dir %{_includedir}/mpich-%{_arch}/bout++
%dir %{_includedir}/mpich-%{_arch}/bout++/bout
%dir %{_includedir}/mpich-%{_arch}/bout++/bout/invert
%dir %{_includedir}/mpich-%{_arch}/bout++/bout/sys
%{_includedir}/mpich-%{_arch}/bout++/*.hxx
%{_includedir}/mpich-%{_arch}/bout++/make.config
%{_includedir}/mpich-%{_arch}/bout++/bout/*.hxx
%{_includedir}/mpich-%{_arch}/bout++/bout/invert/*.hxx
%{_includedir}/mpich-%{_arch}/bout++/bout/sys/*.hxx
%{_includedir}/mpich-%{_arch}/bout++/pvode/*.h
Just use:
%{_includedir}/mpich-%{_arch}/bout++
and:
%{_includedir}/openmpi-%{_arch}/bout++
Also remove the * here:
%{python3_sitearch}/mpich/
%{python3_sitearch}/openmpi/
- Not needed for private libs:
%post mpich -p /sbin/ldconfig
%postun mpich -p /sbin/ldconfig
- It is verboten to glob the whole %{python3_sitelib}/
Be more specific here:
%dir %{python3_sitelib}/*
%{python3_sitelib}/*/*
- Man pages are not part of %doc:
%doc %{_mandir}/man1/bout++*
Man pages should be in the same package as the binary they describe
- I'm not really fond of making a package just for licenses and doc file:
%files common
%doc README.md
%doc CITATION.bib
%doc CITATION.cff
%doc CHANGELOG.md
%doc CONTRIBUTING.md
%license LICENSE
%license LICENSE.GPL
Put them in python%{python3_pkgversion}-%{name} %{name}-openmpi %{name}-mpich
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component