Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: dhcp_probe - Tool for discover DHCP and BootP servers
https://bugzilla.redhat.com/show_bug.cgi?id=624833
Summary: dhcp_probe - Tool for discover DHCP and BootP servers Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: dbruno@fedoraproject.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
SPEC URL: http://dbruno.fedorapeople.org/dhcp_probe/dhcp_probe.spec SRPM URL: http://dbruno.fedorapeople.org/dhcp_probe/dhcp_probe-1.3.0-2.fc13.src.rpm
Description: dchp_probe attempts to discover DHCP and BootP servers on a directly-attached Ethernet network. A network administrator can use this tool to locate unauthorized DHCP and BootP servers.
$ rpmlint -i SPECS/dhcp_probe.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
Daniel Bruno dbruno@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|dhcp_probe - Tool for |Review Request: dhcp_probe |discover DHCP and BootP |- Tool for discover DHCP |servers |and BootP servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
Daniel Bruno dbruno@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
Guillermo Gómez guillermo.gomez@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |guillermo.gomez@gmail.com AssignedTo|nobody@fedoraproject.org |guillermo.gomez@gmail.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
--- Comment #1 from Guillermo Gómez guillermo.gomez@gmail.com 2010-08-17 18:38:49 EDT --- It looks like u have tampered the tarball, u should not do that, use Source1 to include adittional init script.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
Guillermo Gómez guillermo.gomez@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW AssignedTo|guillermo.gomez@gmail.com |nobody@fedoraproject.org Flag|fedora-review? |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
Toshio Ernie Kuratomi a.badger@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |a.badger@gmail.com
--- Comment #2 from Toshio Ernie Kuratomi a.badger@gmail.com 2010-08-17 18:51:46 EDT --- I'm willing to sponsor dbruno. Guillermo will continue the review process and when it's done I will sponsor and he and I will share mentor responsibilities.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
Guillermo Gómez guillermo.gomez@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |guillermo.gomez@gmail.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
--- Comment #3 from Daniel Bruno dbruno@fedoraproject.org 2010-08-17 22:41:01 EDT --- Guillermo and Toshio thanks a lot for the support!
spec: http://dbruno.fedorapeople.org/dhcp_probe/1.3.0-3/dhcp_probe.spec
srpm: http://dbruno.fedorapeople.org/dhcp_probe/1.3.0-3/dhcp_probe-1.3.0-3.fc13.sr...
$ rpmlint SPECS/dhcp_probe.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
--- Comment #4 from Guillermo Gómez guillermo.gomez@gmail.com 2010-08-18 00:36:29 EDT --- 1. Please improve absolute path use in scriptlets for consistency (better use absolute paths)
%post chkconfig --add dhcp_probe << rel path
%preun if [ $1 = 0 ] ; then /sbin/chkconfig --del dhcp_probe << abs path fi
2. Requires are needed for chkconfig and service commands,
http://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscripts_in_spec_f...
3. chkconfig dhcp_probe off would force a configuration change on upgrade, avoid it
4. SysV implement condrestart (and try-restart): restart the service if the service is already running, if not, do nothing
5. SysV implement force-reload: reload the configuration of the service and restart it so that it takes effect
6. Exit Codes for non-Status Actions and Exit Codes for the Status Action needs improovements following Initscripts must be on their best behavior
:) dhcp_probe works fine and builds on koji, just need some love on the initscript
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
--- Comment #5 from Terje Røsten terjeros@phys.ntnu.no 2010-08-18 03:45:27 EDT --- *** Bug 611476 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
Terje Røsten terjeros@phys.ntnu.no changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@phys.ntnu.no
--- Comment #6 from Terje Røsten terjeros@phys.ntnu.no 2010-08-18 03:55:25 EDT --- Only some cosmetic comments:
o have you sent patches upstream or are they from upstream, please add a comment in the spec about the patches? o for better readability add a empty line before the %clean section? o %config(noreplace) %_sysconfdir/dhcp_probe.cf: add {} in sysconfdir macro o %{_mandir}/man8/* -> %{_mandir}/man8/dhcp_probe.8* %{_mandir}/man5/* -> %{_mandir}/man5/dhcp_probe.cf.5*
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
--- Comment #7 from Daniel Bruno dbruno@fedoraproject.org 2010-08-23 23:22:16 EDT --- The new spec and srpm with the improvements.
spec: http://dbruno.fedorapeople.org/dhcp_probe/1.3.0-4/dhcp_probe.spec
srpm: http://dbruno.fedorapeople.org/dhcp_probe/1.3.0-4/dhcp_probe-1.3.0-4.fc13.sr...
$ rpmlint SPECS/dhcp_probe.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
--- Comment #8 from Daniel Bruno dbruno@fedoraproject.org 2010-09-09 09:01:31 EDT --- The new spec and srpm:
spec: http://dbruno.fedorapeople.org/dhcp_probe/1.3.0-5/dhcp_probe.spec
srpm: http://dbruno.fedorapeople.org/dhcp_probe/1.3.0-5/dhcp_probe-1.3.0-5.fc13.sr...
$ rpmlint SPECS/dhcp_probe.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
--- Comment #9 from Guillermo Gómez guillermo.gomez@gmail.com 2010-09-10 17:22:51 EDT --- Koji builds for F12, F13 and F14.
1. SysV implement condrestart (and try-restart): restart the service if the service is already running, if not, do nothing.
minimun implementation suggested:
condrestart|try-restart) rh_status_q || exit 0 restart ;;
2. dhcp_probe..: W: service-default-enabled /etc/rc.d/init.d/dhcp_probe
service default state must be disabled
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
--- Comment #10 from Daniel Bruno dbruno@fedoraproject.org 2010-09-21 18:53:04 EDT --- The new spec and srpm are available:
spec: http://dbruno.fedorapeople.org/dhcp_probe/1.3.0-6/dhcp_probe.spec
srpm: http://dbruno.fedorapeople.org/dhcp_probe/1.3.0-6/dhcp_probe-1.3.0-6.fc13.sr...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
--- Comment #11 from Guillermo Gómez guillermo.gomez@gmail.com 2010-09-23 11:29:53 EDT --- im satisfied with this version. Daniel, now we need the sponsorship.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
Guillermo Gómez guillermo.gomez@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
Toshio Ernie Kuratomi a.badger@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) |
--- Comment #12 from Toshio Ernie Kuratomi a.badger@gmail.com 2010-09-23 12:56:27 EDT --- I've sponsored dbruno. Daniel, feel free to ask questions of both Guillermo and myself :-)
Took a quick look at the spec file and it looks fine.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
--- Comment #13 from Daniel Bruno dbruno@fedoraproject.org 2010-09-24 11:08:35 EDT --- New Package SCM Request ======================= Package Name: dhcp_probe Short Description: Tool for discover DHCP and BootP servers Owners: dbruno Branches: f12 f13 f14 InitialCC: gomix
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
Guillermo Gómez guillermo.gomez@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
--- Comment #14 from Kevin Fenzi kevin@tummy.com 2010-09-25 01:32:06 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2010-09-29 10:19:27 EDT --- dhcp_probe-1.3.0-6.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/dhcp_probe-1.3.0-6.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2010-09-29 11:18:20 EDT --- dhcp_probe-1.3.0-6.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/dhcp_probe-1.3.0-6.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
--- Comment #17 from Fedora Update System updates@fedoraproject.org 2010-09-29 11:42:51 EDT --- dhcp_probe-1.3.0-6.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/dhcp_probe-1.3.0-6.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #18 from Fedora Update System updates@fedoraproject.org 2010-09-30 01:31:50 EDT --- dhcp_probe-1.3.0-6.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update dhcp_probe'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/dhcp_probe-1.3.0-6.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
--- Comment #19 from Fedora Update System updates@fedoraproject.org 2010-10-08 16:33:25 EDT --- dhcp_probe-1.3.0-6.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |dhcp_probe-1.3.0-6.fc13 Resolution| |ERRATA Last Closed| |2010-10-08 16:33:30
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
--- Comment #20 from Fedora Update System updates@fedoraproject.org 2010-10-18 01:45:34 EDT --- dhcp_probe-1.3.0-6.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|dhcp_probe-1.3.0-6.fc13 |dhcp_probe-1.3.0-6.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
--- Comment #21 from Fedora Update System updates@fedoraproject.org 2010-10-19 03:02:53 EDT --- dhcp_probe-1.3.0-6.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=624833
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|dhcp_probe-1.3.0-6.fc14 |dhcp_probe-1.3.0-6.fc12
package-review@lists.fedoraproject.org