Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205309
Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm Product: Fedora Extras Version: devel Platform: All URL: http://search.cpan.org/dist/Algorithm-C3/ OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cweyl@alumni.drew.edu QAContact: fedora-package-review@redhat.com
SRPM URL: http://home.comcast.net/~ckweyl/perl-Algorithm-C3-0.05-1.fc5.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Algorithm-C3.spec
Description: This module implements the C3 algorithm. Most of the uses I have for C3 revolve around class building and metamodels, but it could also be used for things like dependency resolution as well since it tends to do such a nice job of preserving local precendence orderings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205309
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |163776 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205309
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |205314 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205309
------- Additional Comments From pertusus@free.fr 2006-09-06 13:52 EST ------- Why do you use Build instead of the more classical Makefile.PL? I personally don't care, but it is not what is proposed in the README.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205309
------- Additional Comments From cweyl@alumni.drew.edu 2006-09-06 16:38 EST ------- Build with Build.PL is what cpanspec spits out by default if available, as (I'm guessing here it's motivation here) it is a newer model.
From my perspective, it builds just fine, and if upstream ever decides to drop
Makefile.PL support we're all set.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205309
jpo@di.uminho.pt changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jpo@di.uminho.pt
------- Additional Comments From jpo@di.uminho.pt 2006-09-06 17:47 EST ------- A couple of notes about "Makefile.PL vs Build.PL" or "ExtUtils::MakeMaker vs Module::Build"
1. If a perl distro includes both the Build.PL and the Makefile.PL file, there are good chances that the Makefile.PL has been generated from the Build.PL file. In these cases is better to package the module using Build.PL (BR: perl(Module::Build). Note: in the past the generated Makefile.PL not always installed correctly.
2. In the past the documentation of Module::Build stated that Module::Build *would* replace ExtUtils::MakeMaker. This now has been corrected (see the Module::Build changelog) and both installation methods will be supported.
3. In the past the Michael G Schwern's presentation "MakeMaker Is DOOMED! or MakeMaker is dead! Long live Module::Build!" also caused some confusion. (http://schwern.org/~schwern/talks/MakeMaker_Is_DOOMED/slides/slide001.html) Michael Schwern was at the time the perl test guy and the maintainer of ExtUtils::MakeMaker.
4. Module::Build is a perl core module since perl 5.9.4. Perl 5.10 will supported Makefile.PL and Build.PL natively. Right now Module::Build must be installed from CPAN or from a package repository. Module::Build is rather important as it doesn't require external utilities such as make (and its flavours) which is a must if you must support lot of platforms (UNIX, VMS, Win32, ...)
jpo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205309
------- Additional Comments From cweyl@alumni.drew.edu 2006-09-06 18:08 EST ------- Thanks for the most excellent summary, Jose :) Would you mind if I posted that on the wiki somewhere?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205309
------- Additional Comments From jpo@di.uminho.pt 2006-09-06 19:13 EST ------- (In reply to comment #4)
Thanks for the most excellent summary, Jose :) Would you mind if I posted that on the wiki somewhere?
Not at all! Go ahead.
One other thing that I should be placing in the wiki is this rather outdated document http://gsd.di.uminho.pt/jpo/perl/specfiles/. Do you know a good tool to convert HTML pages into wiki formats?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205309
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205309
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From tibbs@math.uh.edu 2006-09-06 23:50 EST ------- Sorry to step into this conversation, but I have some time for reviews, so....
* source files match upstream: d087e68c937e7076bb07396b281685c1 Algorithm-C3-0.05.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: perl(Algorithm::C3) = 0.05 perl-Algorithm-C3 = 0.05-1.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=11, Tests=57, 1 wallclock secs ( 0.32 cusr + 0.14 csys = 0.46 CPU) * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205309
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From cweyl@alumni.drew.edu 2006-09-07 00:47 EST ------- +Import to CVS +Add to owners.list +Bump release, build for devel +devel build succeeds +Request branching (FC-5) +Close bug
Thanks for the review!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205309
paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |paul@city-fan.org
------- Additional Comments From paul@city-fan.org 2006-09-07 06:38 EST ------- (In reply to comment #5)
(In reply to comment #4)
Thanks for the most excellent summary, Jose :) Would you mind if I posted that on the wiki somewhere?
Not at all! Go ahead.
The Packaging/Perl page would have been the obvious place but it's immutable to everyone outside the packaging committee now.
One other thing that I should be placing in the wiki is this rather outdated document http://gsd.di.uminho.pt/jpo/perl/specfiles/. Do you know a good tool to convert HTML pages into wiki formats?
I'll volunteer to transcribe it if you like. Might be better to update it and/or strip out the outdated bits first though.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205309
------- Additional Comments From jpo@di.uminho.pt 2006-09-07 12:06 EST ------- (In reply to comment #8)
(In reply to comment #5)
(In reply to comment #4)
Thanks for the most excellent summary, Jose :) Would you mind if I posted
that
on the wiki somewhere?
Not at all! Go ahead.
The Packaging/Perl page would have been the obvious place but it's immutable to everyone outside the packaging committee now.
And at least a member of the packaging committee :(
One other thing that I should be placing in the wiki is this rather outdated document http://gsd.di.uminho.pt/jpo/perl/specfiles/. Do you know a good tool to convert HTML pages into wiki formats?
I'll volunteer to transcribe it if you like. Might be better to update it and/or strip out the outdated bits first though.
Thanks! That would be great. I will start updating it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm Alias: perl-Algorithm-C3
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205309
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |perl-Algorithm-C3
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm Alias: perl-Algorithm-C3
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205309
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From cweyl@alumni.drew.edu 2007-04-19 16:41 EST ------- Please branch for EL-4, EL-5.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm Alias: perl-Algorithm-C3
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205309
jwboyer@jdub.homelinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Algorithm-C3 - Module for merging hierarchies using the C3 algorithm Alias: perl-Algorithm-C3
https://bugzilla.redhat.com/show_bug.cgi?id=205309
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org