https://bugzilla.redhat.com/show_bug.cgi?id=1240892
Bug ID: 1240892 Summary: Review Request: golang-github-creack-termios - Golang terminal management Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jakub.jedelsky@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://s.stderr.cz/rpm/golang-github-creack-termios.spec SRPM URL: http://s.stderr.cz/rpm/golang-github-creack-termios-0-0.1.git.d60649a.fc22.s... Description: Golang terminal management
This package contains library source intended for building other packages which use creack/termios
Fedora Account System Username: kubo
https://bugzilla.redhat.com/show_bug.cgi?id=1240892
Jakub Jedelsky jakub.jedelsky@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1234182
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1234182 [Bug 1234182] asciinema-v1.1.1 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1240892
--- Comment #1 from Jakub Jedelsky jakub.jedelsky@gmail.com --- rpmlint SPECS/golang-github-creack-termios.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint SRPMS/golang-github-creack-termios-0-0.1.git.d60649a.fc22.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1240892
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jchaloup@redhat.com
--- Comment #2 from Jan Chaloupka jchaloup@redhat.com --- I would recommend to regenerate the spec file with the latest support for secondary architectures. There are other improvements like making devel subpackge noarch and adding arch-specific unit-test-devel subpackage for unit tests.
https://bugzilla.redhat.com/show_bug.cgi?id=1240892
--- Comment #3 from Jakub Jedelsky jakub.jedelsky@gmail.com --- Thanks for info, I'll take a look at it. This one is quite old :)
https://bugzilla.redhat.com/show_bug.cgi?id=1240892
--- Comment #4 from Jan Chaloupka jchaloup@redhat.com --- https://jchaloup.fedorapeople.org/reviews/golang-github-creack-termios/golan...
Summary: - noarch devel subpackage - devel subpackage contain only source codes (nothing else) - unit-test-devel subpackage for CI testing - support for secondary architectures - license in %license tag
package-review@lists.fedoraproject.org