Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915923
Bug ID: 915923 Summary: Review Request: qt5-qtxmlpatterns - Qt5 - QtXmlPatterns component Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: rdieter@math.unl.edu
Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtxmlpatterns.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtxmlpatterns-5.0.1-1.fc18.src.... Description: Qt5 - QtXmlPatterns component Fedora Account System Username: rdieter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915923
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |656997 (kde-reviews) Depends On| |878188 (qt5-qtbase) Alias| |qt5-qtxmlpatterns
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915923
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |928937 (qt-reviews)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915923
--- Comment #1 from Rex Dieter rdieter@math.unl.edu --- Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtxmlpatterns.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtxmlpatterns-5.0.2-1.fc18.src....
%changelog * Thu Apr 11 2013 Rex Dieter rdieter@fedoraproject.org 5.0.2-1 - 5.0.2
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5244022
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915923
Bug 915923 depends on bug 878188, which changed state.
Bug 878188 Summary: Review Request: qt5-qtbase - Qt5 - QtBase components https://bugzilla.redhat.com/show_bug.cgi?id=878188
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=915923
Erik Schilling ablu.erikschilling@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ablu.erikschilling@googlema | |il.com
--- Comment #2 from Erik Schilling ablu.erikschilling@googlemail.com --- Not sure where to mention this issue (here or in the qt quick part), but:
I installed your qt5 packages and then tried to build a project which uses QML. The build itself works fine. However if I run the binary then my UI is not working since there is an error in the qml files:
file:///home/ablu/mana/manamobile/qml/main/ServerPage.qml:76:5: Qt was built without support for xmlpatterns XmlListModel { ^ I installed the xmlpatterns package using your SRPM here. The qt5-base is from the repositories, the other qt5 packages are all SRPM builds from your review requests.
The project I tried to compile is https://github.com/mana/manamobile/ The project itself builds fine against the precompiled qt version of qt-project. So it does not seem to be an issue in that project.
ablu@ablu: ~$ yum info qt5-qtbase Installed Packages Name : qt5-qtbase Arch : i686 Version : 5.0.2 Release : 3.fc19 [...] Repo : installed [...]
ablu@ablu: ~$ yum info qt5-qtxmlpatterns Loaded plugins: auto-update-debuginfo, langpacks, refresh-packagekit Installed Packages Name : qt5-qtxmlpatterns Arch : i686 Version : 5.0.2 Release : 1.fc19 [...] Repo : installed
From repo : /qt5-qtxmlpatterns-5.0.2-1.fc19.i686
[...]
Regards and Thanks a lot for working on this qt5 stuff (I would help doing reviews, but I guess this is out of my league), Erik
https://bugzilla.redhat.com/show_bug.cgi?id=915923
--- Comment #3 from Kevin Kofler kevin@tigcc.ticalc.org --- I guess you need some other qt5 package (probably Qt Quick) rebuilt with BuildRequires: qt5-qtxmlpatterns-devel added.
https://bugzilla.redhat.com/show_bug.cgi?id=915923
--- Comment #4 from Erik Schilling ablu.erikschilling@googlemail.com --- It was qtdeclarative. But thx for the hint! Works great now.
https://bugzilla.redhat.com/show_bug.cgi?id=915923
Dan Horák dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |907398 (sigil-07)
https://bugzilla.redhat.com/show_bug.cgi?id=915923
Dan Horák dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dan@danny.cz Assignee|nobody@fedoraproject.org |dan@danny.cz Flags| |fedora-review?
--- Comment #5 from Dan Horák dan@danny.cz --- formal review is here, see the notes explaining OK* and BAD statuses below:
OK* source files match upstream: a234427a0b9172aa8d1064577a5a1e9f4a86c839 qtxmlpatterns-opensource-src-5.0.2.tar.xz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK* license is open source-compatible. License texts not included in package. OK* latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK* rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths, with correct scriptlets Ok owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in devel subpackage OK pkgconfig files in devel subpackage OK no libtool .la droppings. OK not a GUI app.
- the Source URL doesn't work with the 5.0 series being in the archive - please include the license text in the package - I see 5.1 as the latest, but let's don't mix 5.1 with 5.0 during the review phase - rpmlint complains a bit, but the warnings are harmless qt5-qtxmlpatterns.src:42: W: macro-in-comment %{_bindir} qt5-qtxmlpatterns-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/qtxmlpatterns-opensource-src-5.0.2/src/xmlpatterns/.rcc qt5-qtxmlpatterns-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/qtxmlpatterns-opensource-src-5.0.2/src/xmlpatterns/.rcc qt5-qtxmlpatterns-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/qtxmlpatterns-opensource-src-5.0.2/src/xmlpatterns/.moc qt5-qtxmlpatterns-debuginfo.x86_64: W: hidden-file-or-dir /usr/src/debug/qtxmlpatterns-opensource-src-5.0.2/src/xmlpatterns/.moc qt5-qtxmlpatterns-devel.x86_64: W: no-documentation qt5-qtxmlpatterns-devel.x86_64: W: no-manual-page-for-binary xmlpatterns-qt5 qt5-qtxmlpatterns-devel.x86_64: W: no-manual-page-for-binary xmlpatternsvalidator-qt5 qt5-qtxmlpatterns.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 9 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=915923
--- Comment #6 from Rex Dieter rdieter@math.unl.edu --- Spec URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtxmlpatterns.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/qt5/qt5-qtxmlpatterns-5.0.2-2.fc19.src....
%changelog * Sat Aug 17 2013 Rex Dieter rdieter@fedoraproject.org 5.0.2-2 - %%doc LICENSE.GPL LICENSE.LGPL LGPL_EXCEPTION.txt - update Source URL
https://bugzilla.redhat.com/show_bug.cgi?id=915923
Dan Horák dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | Flags|fedora-review? |fedora-review+
--- Comment #7 from Dan Horák dan@danny.cz --- All issues fixed, package is APPROVED
package-review@lists.fedoraproject.org