[Bug 2259466] New: Review Request: python-dsinternals - Directory Services Internals Library for python
https://bugzilla.redhat.com/show_bug.cgi?id=2259466
Bug ID: 2259466 Summary: Review Request: python-dsinternals - Directory Services Internals Library for python Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: rebus@seznam.cz QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://rebus.fedorapeople.org/python-dsinternals.spec SRPM URL: https://rebus.fedorapeople.org/python-dsinternals-1.2.4-1.fc39.src.rpm
Description: Directory Services Internals Library. Python native library containing necessary classes, functions and structures to interact with Windows Active Directory. Installation python3 -m pip install dsinternals ContributingPull requests are welcome. Feel free to open an issue if...
Fedora Account System Username: rebus
https://bugzilla.redhat.com/show_bug.cgi?id=2259466
--- Comment #1 from Michal Ambroz rebus@seznam.cz --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=112144545
https://bugzilla.redhat.com/show_bug.cgi?id=2259466
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |http://github.com/p0daliriu | |s/pydsinternals
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6937237 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2259466
Steve Cossette farchord@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |farchord@gmail.com Doc Type|--- |If docs needed, set a value
--- Comment #3 from Steve Cossette farchord@gmail.com --- Hello Michal,
Is there a reason why this package doesn't use the %pyproject_buildrequires macro to build the python requirements (Ref: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_build_mac...
https://bugzilla.redhat.com/show_bug.cgi?id=2259466
--- Comment #4 from Michal Ambroz rebus@seznam.cz --- Hello Steve, I would love to use the pyproject macros, but I plan to use the package acros the EPELs as well and pyproject is not on epel7 and having some issues on rhel8. I would preffer to have one spec for all supported platforms.
https://bugzilla.redhat.com/show_bug.cgi?id=2259466
--- Comment #5 from Steve Cossette farchord@gmail.com --- Would it then be possible to logicgate the sections, i.e. have el7 use the current version, but have el8+ and fedora use the new macros?
https://bugzilla.redhat.com/show_bug.cgi?id=2259466
Michal Ambroz rebus@seznam.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2255010
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2255010 [Bug 2255010] F40FailsToInstall: python3-impacket
https://bugzilla.redhat.com/show_bug.cgi?id=2259466
--- Comment #6 from Michal Ambroz rebus@seznam.cz --- Spec URL: https://rebus.fedorapeople.org/python-dsinternals.spec SRPM URL: https://rebus.fedorapeople.org/python-dsinternals-1.2.4-2.fc39.src.rpm
Hello, here the attempt to run the %generate_buildrequires/%pyproject_buildrequires if available https://copr.fedorainfracloud.org/coprs/rebus/infosec/build/6942085/
It is still failing on epel8 even it should not. Spec is requesting python%{python3_pkgversion}-setuptools, which on epel3 gets resolved as python3-setuptools, but then the build complains about missing setuptools ... probably module for python 3.11
I am thinking of swithcing back to legacy py3_build/py3_install ... that one would work even on rhel7 :(...
https://bugzilla.redhat.com/show_bug.cgi?id=2259466
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2010000 --> https://bugzilla.redhat.com/attachment.cgi?id=2010000&action=edit The .spec file difference from Copr build 6937237 to 6944190
https://bugzilla.redhat.com/show_bug.cgi?id=2259466
--- Comment #8 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6944190 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2259466
--- Comment #9 from Steve Cossette farchord@gmail.com --- (In reply to Michal Ambroz from comment #6)
Spec URL: https://rebus.fedorapeople.org/python-dsinternals.spec SRPM URL: https://rebus.fedorapeople.org/python-dsinternals-1.2.4-2.fc39.src.rpm
Hello, here the attempt to run the %generate_buildrequires/%pyproject_buildrequires if available https://copr.fedorainfracloud.org/coprs/rebus/infosec/build/6942085/
It is still failing on epel8 even it should not. Spec is requesting python%{python3_pkgversion}-setuptools, which on epel3 gets resolved as python3-setuptools, but then the build complains about missing setuptools ... probably module for python 3.11
I am thinking of swithcing back to legacy py3_build/py3_install ... that one would work even on rhel7 :(...
The el7 build seems to be failing because of
``` Error: No Package found for pyproject-rpm-macros ```
As far as el8 goes, yeah I would probably just revert back to the old python macros for that specific version, I'm guessing your haunch is right here.
I'm not sure what Fedora's guidelines are as far as using a mixed legacy/pywheel macro set in a spec meant to be used in older versions of epel, to be 100% honest here.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com