https://bugzilla.redhat.com/show_bug.cgi?id=759818
Miroslav Suchý <msuchy(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |msuchy(a)redhat.com
Assignee|nobody(a)fedoraproject.org |msuchy(a)redhat.com
--- Comment #8 from Miroslav Suchý <msuchy(a)redhat.com> ---
Please use macros consistently
I.e. instead of $RPM_BUILD_ROOT please use %{buildroot}.
BuildRoot tag is not needed unless you target EL5.
French translation of description:
1) does not start with capital
2) does not end with dot
3) is not full translation of the original text
Therefore I would suggest to remove it completly.
%install
%{__rm} -rf $RPM_BUILD_ROOT
is not needed unless you target EL5
The same for
%clean
%{__rm} -rf $RPM_BUILD_ROOT
and
%defattr(-,root,root,-)
You should mark COPYING as license. i.e. use
%license COPYING
Dist tag should be used conditionally:
%{?dist}
- Sources used to build the package match the upstream source, as provided
in the spec URL.
Note: Upstream MD5sum check error, diff is in /tmp/review-buffer/diff.txt
See:
http://fedoraproject.org/wiki/Packaging/SourceURL
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component