https://bugzilla.redhat.com/show_bug.cgi?id=1468995
Bug ID: 1468995 Summary: Review Request: python-geopandas - Geographic pandas extensions Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: quantum.analyst@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/geopy/fedora-rawhide... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/qulogic/geopy/fedora-rawhide... Description: The goal of GeoPandas is to make working with geospatial data in Python easier. It combines the capabilities of Pandas and Shapely, providing geospatial operations in Pandas and a high-level interface to multiple geometries to Shapely. GeoPandas enables you to easily do operations in Python that would otherwise require a spatial database such as PostGIS.
I am seeking a sponsor; some informal reviews I have done:
https://bugzilla.redhat.com/show_bug.cgi?id=1440992#c1 https://bugzilla.redhat.com/show_bug.cgi?id=1440971#c1 https://bugzilla.redhat.com/show_bug.cgi?id=1433757#c2 https://bugzilla.redhat.com/show_bug.cgi?id=1368855#c14
Fedora Account System Username: qulogic
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR) Depends On| |1468877, 1468872
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=1468872 [Bug 1468872] Review Request: python-descartes - Use geometric objects as Matplotlib paths and patches https://bugzilla.redhat.com/show_bug.cgi?id=1468877 [Bug 1468877] Review Request: python-fiona - read and write spatial data files
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
--- Comment #1 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Also depends on a new Rtree, but I'm hoping that can be updated by the time the other requirements are reviewed.
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@in.waw.pl Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review?
--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Use use "pandas" and "Pandas", inconsistently.
I'd also recommend the trick from https://bugzilla.redhat.com/show_bug.cgi?id=1468873#c2 to avoid repeating the lengthy description text.
Hmm, what's the deal with rtree? http://toblerity.org/rtree/ shows 0.7 as the latest version. Can you open a bug against the python-Rtree package? Maybe the maintainer needs to be informed about a new upstream? It also needs a python3 version for this review to proceed.
Everything looks good, but I'll wait with the rest of review until the rtree situation improves.
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1481100
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1481100 [Bug 1481100] python-Rtree is outdated and lacks Python 3 support
https://bugzilla.redhat.com/show_bug.cgi?id=1468995 Bug 1468995 depends on bug 1468872, which changed state.
Bug 1468872 Summary: Review Request: python-descartes - Use geometric objects as Matplotlib paths and patches https://bugzilla.redhat.com/show_bug.cgi?id=1468872
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1468995 Bug 1468995 depends on bug 1481100, which changed state.
Bug 1481100 Summary: python-Rtree is outdated and lacks Python 3 support https://bugzilla.redhat.com/show_bug.cgi?id=1481100
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
--- Comment #3 from Elliott Sales de Andrade quantum.analyst@gmail.com --- So new Rtree is in Rawhide and fiona is also built. There was a new release of GeoPandas in the meantime, which I've tried to package, but there are a few new issues on non-x86 arches. https://github.com/geopandas/geopandas/issues/552
https://bugzilla.redhat.com/show_bug.cgi?id=1468995 Bug 1468995 depends on bug 1468877, which changed state.
Bug 1468877 Summary: Review Request: python-fiona - read and write spatial data files https://bugzilla.redhat.com/show_bug.cgi?id=1468877
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
--- Comment #4 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- The latest version in your copr: spec: https://copr-be.cloud.fedoraproject.org/results/qulogic/geopy/fedora-rawhide... srpm: https://copr-be.cloud.fedoraproject.org/results/qulogic/geopy/fedora-rawhide...
It seems that there is no python2-Rtree and python3-Rtree. IIUC, there used to be a python-Rtree binary package, but now there's only python2-rtree and python3-rtree, and python2-rtree provides python-Rtree for compatibility. So this version doesn't build in mock.
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
--- Comment #5 from Elliott Sales de Andrade quantum.analyst@gmail.com --- There's an upstream patch for a spatialindex crash that's triggered by geopandas; if that can be applied, then I can finish this request up.
https://github.com/libspatialindex/libspatialindex/pull/108
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |davejohansen@gmail.com Flags| |needinfo?(davejohansen@gmai | |l.com)
--- Comment #6 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Let's ask the maintainer.
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
--- Comment #7 from Elliott Sales de Andrade quantum.analyst@gmail.com --- I've opened a PR on Pagure with the patch: https://src.fedoraproject.org/rpms/spatialindex/pull-request/1
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
Volker Fröhlich volker27@gmx.at changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@gmx.at
--- Comment #8 from Volker Fröhlich volker27@gmx.at --- Updated in F25 through Rawhide, thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
--- Comment #9 from Volker Fröhlich volker27@gmx.at --- You might want to add the GIS-related packages on this page: https://fedoraproject.org/wiki/GIS
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(davejohansen@gmai | |l.com) |
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
--- Comment #10 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Spec URL: https://qulogic.fedorapeople.org/python-geopandas.spec SRPM URL: https://qulogic.fedorapeople.org/python-geopandas-0.3.0-2.fc26.src.rpm
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23488964
Now working on all arches (though it's a noarch package itself).
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
--- Comment #12 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-geopandas
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #11 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- + package name is OK + license is acceptable for Fedora (BSD) + license is specified correctly + modern python packaging template is used + %python_provide is used + BuildRequires/Requires/Provides look OK + %check is present and passes + package builds and installs OK + fedora-review finds no issues + rpmlint only finds false positive spelling issues
Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- python-geopandas-0.3.0-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8f5af13691
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- python-geopandas-0.3.0-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8f5af13691
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- python-geopandas-0.3.0-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8f5af13691
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- python-geopandas-0.3.0-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8f5af13691
https://bugzilla.redhat.com/show_bug.cgi?id=1468995
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-12-19 14:45:24
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- python-geopandas-0.3.0-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org