Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: ibus-table-others- Various tables for IBus-Table
https://bugzilla.redhat.com/show_bug.cgi?id=630932
Summary: Review Request: ibus-table-others- Various tables for IBus-Table Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nkumar@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://nkumar.fedorapeople.org/ibus-table-others/ibus-table-others.spec SRPM URL: http://nkumar.fedorapeople.org/ibus-table-others/ibus-table-others-1.3.0.201... Description: The package contains various IBus-Tables which include languages of Latin-America, Europe, Southeast Asia, as well as math and other symbols
Hi! I have just finished packaging ibus-table-others, and I would appreciate a review so that the package can get into fedora.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
--- Comment #1 from Jens Petersen petersen@redhat.com 2010-09-09 01:48:35 EDT --- *** Bug 595551 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
--- Comment #2 from Chen Lei supercyper1@gmail.com 2010-09-14 13:24:13 EDT --- I'd like to see this package to be splitted into more subpackages.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
--- Comment #3 from Naveen Kumar nkumar@redhat.com 2010-09-20 08:10:59 EDT --- (In reply to comment #2)
I'd like to see this package to be splitted into more subpackages.
yep, I will do that, just give me some time.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
--- Comment #4 from Naveen Kumar nkumar@redhat.com 2010-09-28 06:09:58 EDT --- Updated Spec URL: http://nkumar.fedorapeople.org/ibus-table-others/1.3.0.20100907-2/ibus-table...
Updated SRPM URL: http://nkumar.fedorapeople.org/ibus-table-others/1.3.0.20100907-2/ibus-table...
Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2493776
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
--- Comment #5 from Chen Lei supercyper1@gmail.com 2010-09-30 05:12:54 EDT --- 1. Since you already split ibus-table-others into several subpackages, so Obsoletes and Provides fields are useless.
2. %package ibus-table-code -> %package -n ibus-table-code
%files ibus-table-code -> %files -n ibus-table-code
3. %files %defattr(-,root,root,-) %doc AUTHORS COPYING README
Those line can be removed.
4.
I suggest to add a blank line between Summary: and %description.
5.
I suggest to use rm and make to macros %__make and %__rm
6. Requires: ibus-table >= 1.2.0.20090912 You should move this line to every subpackage separately.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
--- Comment #6 from Naveen Kumar nkumar@redhat.com 2010-09-30 09:07:30 EDT --- (In reply to comment #5)
- Since you already split ibus-table-others into several subpackages, so
Obsoletes and Provides fields are useless.
I have not removed Obsoletes field from the subpackages, since there were packages with the same name before kaio joined them in ibus-table-others. The tables are same.
Updated Spec URL: http://nkumar.fedorapeople.org/ibus-table-others/1.3.0.20100907-3/ibus-table...
Updated SRPM URL: http://nkumar.fedorapeople.org/ibus-table-others/1.3.0.20100907-3/ibus-table...
Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2503543
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
--- Comment #7 from Naveen Kumar nkumar@redhat.com 2010-10-06 06:14:03 EDT --- Updated Spec URL: http://nkumar.fedorapeople.org/ibus-table-others/1.3.0.20100907-4/ibus-table...
Updated SRPM URL: http://nkumar.fedorapeople.org/ibus-table-others/1.3.0.20100907-4/ibus-table...
Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2517280
* Wed Oct 6 2010 Naveen Kumar nkumar@redhat.com - 1.3.0.20100907-4 - delete all Obsoletes fields in spec - removed BuildRoot as specified in new guidelines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
--- Comment #8 from Naveen Kumar nkumar@redhat.com 2010-10-12 06:26:43 EDT --- @Chen Lei If you have time, can you please finish the next round of review, so that if there are no errors, we can move it to fedora. Waiting for your reply...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
--- Comment #9 from Parag AN(पराग) panemade@gmail.com 2010-10-19 06:37:03 EDT --- + Koji build=> http://koji.fedoraproject.org/koji/taskinfo?taskID=2542593 + rpmlint output ibus-table-cyrillic.noarch: W: spelling-error %description -l en_US rustrad -> rust rad, rust-rad, frustrated ibus-table-cyrillic.noarch: W: spelling-error %description -l en_US yawerty -> yawmeter, QWERTY, qwerty ibus-table-latin.noarch: W: spelling-error %description -l en_US ipa -> IPA, pa, nipa ibus-table-latin.noarch: W: spelling-error %description -l en_US sampa -> sampan, salpa, pampa ibus-table-others.src: W: no-buildroot-tag ibus-table-translit.noarch: W: spelling-error %description -l en_US ua -> ya, us, u
+ source verified with upstream url as (sha1sum) a6b347fa2f127911ebe8a1c5752382cb1df1c6b2 ibus-table-others-1.3.0.20100907.tar.gz a6b347fa2f127911ebe8a1c5752382cb1df1c6b2 ibus-table-others-1.3.0.20100907.tar.gz.srpm
Suggestions: 1) drop the following options to %configure --disable-static, --prefix
2) Drop the cleaning of buildroot in %install, that mean following line %__rm -rf $RPM_BUILD_ROOT
3) Good not to use macros for make
4) Drop the %clean section
5) I will suggest dropping %doc from all subpackages as those already requires main package and adding following %files %doc AUTHORS COPYING README
6) Drop the versions from BR: and R: for ibus-table and ibus-table-devel, as we already used to build the required dependencies in release and then this package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
--- Comment #10 from Naveen Kumar nkumar@redhat.com 2010-10-19 09:14:01 EDT --- Updated Spec URL: http://nkumar.fedorapeople.org/ibus-table-others/1.3.0.20100907-5/ibus-table...
Updated SRPM URL: http://nkumar.fedorapeople.org/ibus-table-others/1.3.0.20100907-5/ibus-table...
Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2543046
* Tue Oct 19 2010 Naveen Kumar nkumar@redhat.com - 1.3.0.20100907-5 - dropped --disable-static & --prefix from configure - Dropped the cleaning of buildroot - macros removed from make - clean section dropped - doc moved to main package - versions from BuildRequires and Requires removed
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #11 from Parag AN(पराग) panemade@gmail.com 2010-10-20 02:35:51 EDT --- There looks some problem with translit database. Please look into fixing that issue first.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
--- Comment #12 from Naveen Kumar nkumar@redhat.com 2010-10-20 05:09:38 EDT --- Thanks Parag! Yep I will try and fix it as soon as possible.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
--- Comment #13 from Naveen Kumar nkumar@redhat.com 2010-10-20 05:22:06 EDT --- New Package CVS Request ======================= Package Name: ibus-table-others Short Description: The package contains various IBus-Tables which include languages of Latin-America, Europe, Southeast Asia, as well as math and other symbols Owners: nkumar Branches: F-13 F-14 rawhide InitialCC: i18n-team
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
Naveen Kumar nkumar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
--- Comment #14 from Kevin Fenzi kevin@tummy.com 2010-10-21 09:28:07 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
--- Comment #15 from Naveen Kumar nkumar@redhat.com 2010-10-22 05:08:30 EDT ---
(In reply to comment #14)
Git done (by process-git-requests).
Thanks for the git :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630932
Naveen Kumar nkumar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE Last Closed| |2010-10-22 07:42:57
package-review@lists.fedoraproject.org