https://bugzilla.redhat.com/show_bug.cgi?id=824061
--- Comment #5 from Parag AN(पराग) <panemade(a)gmail.com> ---
Review:-
+ Koji build used ->http://koji.fedoraproject.org/koji/taskinfo?taskID=4094915
+ rpmlint on rpms gave
fcitx-unikey.src: W: invalid-url Source0:
http://fcitx.googlecode.com/files/fcitx-unikey-0.1.0.tar.xz HTTP Error 404: Not
Found
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
==> This can be ignored
+ Source verified with upstream as (sha1sum)
ef57f512d3ded16f6656be5e07e4465cbf13ffd5 fcitx-unikey-0.1.0.tar.xz
ef57f512d3ded16f6656be5e07e4465cbf13ffd5 ../SOURCES/fcitx-unikey-0.1.0.tar.xz
Suggestions:
1) each pushd command should have corresponding popd. please add it in %build
2) I am not sure about final license tag. As ukengine part is in LGPLv2+,
VnConv is in GPLv2+ and your own code is in GPLv3+.
Can you check with upstream? Guess you need to change your code from GPLv3+ to
GPLv2+
3) The correct way to handle locale files is remove manually generation of
%{name}.lang in spec file and use "%find_lang %{name}" at the end of %install
section. See
https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
--
You are receiving this mail because:
You are on the CC list for the bug.