https://bugzilla.redhat.com/show_bug.cgi?id=2251785
--- Comment #12 from Tom Rix <trix(a)redhat.com> ---
License: Apache-2.0
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Apache License 2.0", "*No
copyright*
Apache License 2.0", "BSD 3-Clause License", "MIT License",
"Apache
License 2.0 and/or Intel Open Source License", "MIT License and/or
zlib License", "Apache License", "*No copyright* MIT
License", "*No
copyright* Apache License 2.0 and/or MIT License", "GNU General Public
License, Version 2", "BSD 3-Clause License and/or GNU General Public
License, Version 2", "Apache License 2.0 and/or MIT License",
"Apache
License 2.0 and/or Boost Software License 1.0", "Apache License 2.0
and/or BSD 3-Clause License", "Apache License 2.0 [generated file]",
"Apache License 2.0 and/or Historical Permission Notice and
Disclaimer". 5539 files have unknown license. Detailed output of
licensecheck in /home/trix/reviews/review-openvino/licensecheck.txt
Your license: file is not complete.
Since you have bundled components, go into detail which of these licenses are
for the main package and which are for the others.
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib64/python3.12/site-packages,
/usr/lib64/python3.12, /usr/lib64/pkgconfig,
/usr/lib64/openvino-2024.0.0, /usr/lib64/cmake
Need to add %dir's here ex/
%dir %_libdir/openvino-2024.0.0
ExclusiveArch: x86_64
%ifarch x86_64
BuildRequires: xbyak-devel
%endif
This ifarch check is not needed.
Provides: bundled(onednn)
should have a bundled(onednn) == version
similar for mlas
Requires: lib%{name}-ir-frontend = %{version}
Requires: lib%{name}-pytorch-frontend = %{version}
Recommends: %{name}-auto-plugin = %{version}
Recommends: %{name}-auto-batch-plugin = %{version}
Recommends: %{name}-hetero-plugin = %{version}
Recommends: %{name}-intel-cpu-plugin = %{version}
This is an overly complicated use of subpackages, most (all?) have a single
*.so
Reduce the subpackages to just the main, python and devel or make a strong case
for each.
-DCMAKE_CXX_FLAGS="%{optflags} -Wformat -Wformat-security" \
Should be redundant, why is this needed ?
-python package seems to missing its distinfo/egg dir.
The should be a %check or some option -test subpackage.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2251785
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...