https://bugzilla.redhat.com/show_bug.cgi?id=1364644
Bug ID: 1364644 Summary: Review Request: nodejs-grunt-simple-mocha - A simple wrapper for running tests with Mocha Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: jsmith.fedora@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Depends On: 1364643 Blocks: 956806 (nodejs-reviews), 1269538 (IoT)
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-grunt-simple-mocha/nodejs-g... SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-grunt-simple-mocha/nodejs-g... Description: A simple wrapper for running tests with Mocha Fedora Account System Username: jsmith
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora https://bugzilla.redhat.com/show_bug.cgi?id=1364643 [Bug 1364643] Review Request: nodejs-grunt-contrib-jshint - Validate files with JSHint
https://bugzilla.redhat.com/show_bug.cgi?id=1364644
Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |vanmeeuwen+fedora@kolabsys. | |com
https://bugzilla.redhat.com/show_bug.cgi?id=1364644
--- Comment #1 from Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com --- This one does have rpmlint complain about the wrong interpreter as well. You mentioned the use of /usr/bin/node over /usr/bin/env node was not a packaging guideline yet ratified.
I take it this may involve https://fedoraproject.org/wiki/Script_Interpreters_(draft), but the main reasons listed there are not my concern. The RPM dependency side-note is a bigger concern. My main concern is the ability to manipulate what is executed by the user (say, env node=~/bin/node and worse).
In any case, rpmlint reports it as an error;
nodejs-grunt-simple-mocha.noarch: E: wrong-script-interpreter /usr/lib/node_modules/grunt-simple-mocha/bin/grunt-simple-mocha /usr/bin/env node
https://bugzilla.redhat.com/show_bug.cgi?id=1364644
Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1364644
--- Comment #2 from Jared Smith jsmith.fedora@gmail.com --- Fixed.
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-grunt-simple-mocha/nodejs-g... SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-grunt-simple-mocha/nodejs-g...
https://bugzilla.redhat.com/show_bug.cgi?id=1364644
Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1364644
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-grunt-simple-mocha
https://bugzilla.redhat.com/show_bug.cgi?id=1364644
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2016-08-12 13:12:31
--- Comment #4 from Jared Smith jsmith.fedora@gmail.com --- In rawhide, closing bug
https://bugzilla.redhat.com/show_bug.cgi?id=1364644
--- Comment #5 from Jared Smith jsmith.fedora@gmail.com --- In rawhide, closing bug
https://bugzilla.redhat.com/show_bug.cgi?id=1364644
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1387531 (Node-RED)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1387531 [Bug 1387531] Package tracker for supporting Node-RED
https://bugzilla.redhat.com/show_bug.cgi?id=1364644
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|1269538 (IoT) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora
package-review@lists.fedoraproject.org