https://bugzilla.redhat.com/show_bug.cgi?id=1480958
Bug ID: 1480958 Summary: Review Request: golang-github-BurntSushi-freetype-go - A fork of freetype-go with bounding box calculations Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: sensor.wen@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8... SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x8...
Description: A fork of freetype-go with bounding box calculations
Fedora Account System Username: mosquito
https://bugzilla.redhat.com/show_bug.cgi?id=1480958
sensor.wen@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1465889 | |(DeepinDEPackageReview)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1480958
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Shouldn't the Release tag include the git hash? There seems to be no released version.
- Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/gocode/src/github.com/BurntSushi/freetype-go See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
License tag is incomplete: https://github.com/BurntSushi/freetype-go/blob/master/LICENSE says GPLv2+ or "The FreeType License". This is the same offer that freetype provides. I think it should be "License: GPLv2+ or FTL".
+ package name is OK + license is acceptable (see above) - license is not specified correctly + latest version + P/R/BR look OK + builds and install OK + fedora-review and rmplint are happy (modulo the issue listed above)
rpmlint: golang-github-BurntSushi-freetype-go-unit-test-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings.
Package is APPROVED. Please fix the License and Release tags when importing.
https://bugzilla.redhat.com/show_bug.cgi?id=1480958
--- Comment #2 from sensor.wen@gmail.com --- SPEC: https://raw.githubusercontent.com/FZUG/repo/b37e00151f173afd6f092c29868e2b59...
Thanks I fixed it.
https://bugzilla.redhat.com/show_bug.cgi?id=1480958
--- Comment #3 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-BurntSushi-freetype-go
https://bugzilla.redhat.com/show_bug.cgi?id=1480958
--- Comment #4 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-BurntSushi-freetype-go
https://bugzilla.redhat.com/show_bug.cgi?id=1480958
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- golang-github-BurntSushi-freetype-go-0-0.1.gitb763ddb.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8886feab4c
https://bugzilla.redhat.com/show_bug.cgi?id=1480958
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1480958
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- golang-github-BurntSushi-freetype-go-0-0.1.gitb763ddb.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8886feab4c
https://bugzilla.redhat.com/show_bug.cgi?id=1480958
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sztsian@gmail.com Alias| |golang-github-BurntSushi-fr | |eetype-go
https://bugzilla.redhat.com/show_bug.cgi?id=1480958
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed| |2018-07-22 09:30:30
--- Comment #7 from Zamir SUN sztsian@gmail.com --- This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort.
https://bugzilla.redhat.com/show_bug.cgi?id=1480958
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- golang-github-BurntSushi-freetype-go-0-0.5.20181114gite2365df.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c52b9f5b47
https://bugzilla.redhat.com/show_bug.cgi?id=1480958
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- golang-github-BurntSushi-freetype-go-0-0.5.20181114gite2365df.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c52b9f5b47
package-review@lists.fedoraproject.org