https://bugzilla.redhat.com/show_bug.cgi?id=1382928
Bug ID: 1382928 Summary: Review Request: perl-HTTP-Entity-Parser - PSGI compliant HTTP Entity Parser Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rc040203@freenet.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-HTTP-Entity-Parser.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-HTTP-Entity-Parser-0.18-1.fc... Description: HTTP::Entity::Parser is a PSGI-compliant HTTP Entity parser. This module also is compatible with HTTP::Body. Unlike HTTP::Body, HTTP::Entity::Parser reads HTTP entities from PSGI's environment $env->{'psgi.input'} and parses it. This module supports application/x-www-form-urlencoded, multipart/form- data and application/json.
Fedora Account System Username: corsepiu
https://bugzilla.redhat.com/show_bug.cgi?id=1382928
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1382923 Depends On| |1382926, 1382922
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1382922 [Bug 1382922] Review Request: perl-WWW-Form-UrlEncoded - Parser and builder for application/x-www-form-urlencoded https://bugzilla.redhat.com/show_bug.cgi?id=1382923 [Bug 1382923] perl-Plack-1.0042 is available https://bugzilla.redhat.com/show_bug.cgi?id=1382926 [Bug 1382926] Review Request: perl-HTTP-MultiPartParser - HTTP MultiPart Parser
https://bugzilla.redhat.com/show_bug.cgi?id=1382928 Bug 1382928 depends on bug 1382922, which changed state.
Bug 1382922 Summary: Review Request: perl-WWW-Form-UrlEncoded - Parser and builder for application/x-www-form-urlencoded https://bugzilla.redhat.com/show_bug.cgi?id=1382922
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1382928
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jplesnik@redhat.com Assignee|nobody@fedoraproject.org |jplesnik@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1382928
--- Comment #1 from Jitka Plesnikova jplesnik@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed
BuildRequires TODO: Remove perl(Module::Build) from build-require, it is not used FIX: Please add following build-requires: - perl(base) - t/Util.pm:5 - perl(Carp) - lib/HTTP/Entity/Parser/MultiPart.pm:7 - perl(Exporter) - t/Util.pm:5 - perl(Fcntl) - lib/HTTP/Entity/Parser/MultiPart.pm:8 - perl(File::Basename) - t/01_content_type/multipart.t:8 - perl(HTTP::Headers) - t/01_content_type/multipart.t:6 - perl(IO::File) - t/Util.pm:6 - perl(strict) - lib/HTTP/Entity/Parser.pm:4 - perl(utf8) - t/01_content_type/json.t:6 - perl(warnings) - lib/HTTP/Entity/Parser.pm:5
$ rpm -qp --requires perl-HTTP-Entity-Parser-0.18-1.fc26.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(:VERSION) >= 5.8.5 1 perl(Carp) 1 perl(Encode) 1 perl(Fcntl) 1 perl(File::Temp) 1 perl(HTTP::MultiPartParser) 1 perl(JSON::MaybeXS) 1 perl(Module::Load) 1 perl(Stream::Buffered) 1 perl(WWW::Form::UrlEncoded) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.
$ rpm -qp --provides perl-HTTP-Entity-Parser-0.18-1.fc26.noarch.rpm | sort | uniq -c 1 perl(HTTP::Entity::Parser) = 0.18 1 perl(HTTP::Entity::Parser::JSON) 1 perl(HTTP::Entity::Parser::MultiPart) 1 perl(HTTP::Entity::Parser::OctetStream) 1 perl(HTTP::Entity::Parser::UrlEncoded) 1 perl-HTTP-Entity-Parser = 0.18-1.fc26 Binary provides are Ok.
Rpmlint is ok. It reports only spelling errors.
TODO: Please packed 'eg' to %doc.
Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file.
The package is not approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1382928
--- Comment #2 from Ralf Corsepius rc040203@freenet.de --- Updated version: Spec URL: https://corsepiu.fedorapeople.org/packages/perl-HTTP-Entity-Parser.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-HTTP-Entity-Parser-0.18-2.fc...
https://bugzilla.redhat.com/show_bug.cgi?id=1382928
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Jitka Plesnikova jplesnik@redhat.com ---
BuildRequires TODO: Remove perl(Module::Build) from build-require, it is not used
-BuildRequires: perl(Module::Build) Ok.
FIX: Please add following build-requires:
- perl(base) - t/Util.pm:5
- perl(Carp) - lib/HTTP/Entity/Parser/MultiPart.pm:7
- perl(Exporter) - t/Util.pm:5
- perl(Fcntl) - lib/HTTP/Entity/Parser/MultiPart.pm:8
- perl(File::Basename) - t/01_content_type/multipart.t:8
- perl(HTTP::Headers) - t/01_content_type/multipart.t:6
- perl(IO::File) - t/Util.pm:6
- perl(strict) - lib/HTTP/Entity/Parser.pm:4
- perl(utf8) - t/01_content_type/json.t:6
- perl(warnings) - lib/HTTP/Entity/Parser.pm:5
+BuildRequires: perl(Carp) +BuildRequires: perl(Exporter) +BuildRequires: perl(Fcntl) +BuildRequires: perl(File::Basename) +BuildRequires: perl(HTTP::Headers) +BuildRequires: perl(IO::File) +BuildRequires: perl(base) +BuildRequires: perl(strict) +BuildRequires: perl(utf8) +BuildRequires: perl(warnings) Ok.
The package is approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1382928
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-HTTP-Entity-Parser
https://bugzilla.redhat.com/show_bug.cgi?id=1382928 Bug 1382928 depends on bug 1382926, which changed state.
Bug 1382926 Summary: Review Request: perl-HTTP-MultiPartParser - HTTP MultiPart Parser https://bugzilla.redhat.com/show_bug.cgi?id=1382926
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1382928 Bug 1382928 depends on bug 1382926, which changed state.
Bug 1382926 Summary: Review Request: perl-HTTP-MultiPartParser - HTTP MultiPart Parser https://bugzilla.redhat.com/show_bug.cgi?id=1382926
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|ERRATA |---
https://bugzilla.redhat.com/show_bug.cgi?id=1382928 Bug 1382928 depends on bug 1382926, which changed state.
Bug 1382926 Summary: Review Request: perl-HTTP-MultiPartParser - HTTP MultiPart Parser https://bugzilla.redhat.com/show_bug.cgi?id=1382926
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1382928
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- perl-HTTP-Entity-Parser-0.18-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-030fe5a9b3
https://bugzilla.redhat.com/show_bug.cgi?id=1382928
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1382928
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- perl-HTTP-Entity-Parser-0.18-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-030fe5a9b3
https://bugzilla.redhat.com/show_bug.cgi?id=1382928
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-11-30 00:28:01
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- perl-HTTP-Entity-Parser-0.18-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org